1978360 - New wpt failures in /css/css-view-transitions/column-span-during-transition-doesnt-skip.html

Status: RESOLVED FIXED

(Core :: CSS Parsing and Computation, defect)

Description

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Syncing wpt PR 52793 found new untriaged test failures in CI

Tests Affected

Firefox-only failures

• /css/css-view-transitions/column-span-during-transition-doesnt-skip.html [wpt.fyi]: FAIL [Gecko-android-em-7.0-x86_64-lite-qr-opt-geckoview, Gecko-android-em-7.0-x86_64-qr-debug-geckoview, Gecko-android-em-7.0-x86_64-qr-opt-geckoview, Gecko-linux2404-64-opt, GitHub], PASS [Gecko-linux2404-64-debug, Gecko-windows11-64-24h2-debug, Gecko-windows11-64-24h2-opt]

CI Results

Gecko CI (Treeherder)
GitHub PR Head

Notes

These updates will be on mozilla-central once bug 1968615 lands.

Note: this bug is for tracking fixing the issues and is not
owned by the wpt sync bot.

This bug is linked to the relevant tests by an annotation in
https://github.com/web-platform-tests/wpt-metadata. These annotations
can be edited using the wpt interop dashboard
https://jgraham.github.io/wptdash/

If this bug is split into multiple bugs, please also update the
annotations, otherwise we are unable to track which wpt issues are
already triaged. Resolving as duplicate or closing this issue should
be cause the bot to automatically update or remove the annotation.

Comment 1

[Emilio Cobos Álvarez (:emilio)]

Ah, so I think I see what's going on... What happens is that setting .columns causes us to recreate the frame tree, which for reasons loses the capture.

I think that's a separate bug tho. To test that we don't skip column-span: all stuff, we could just move the .classList.add("fragment") inside the startViewTransitionCallback(). Would you be fine with that change matt, or would it somehow defeat the purpose of the test?

Comment 2

[Emilio Cobos Álvarez (:emilio)]

Matt reached out on slack (because he can't log into his bugzilla account r/n), and said that was fine.

Comment 3

[Emilio Cobos Álvarez (:emilio)]

Attachment: Bug 1978360 - Make column-span-during-transition-doesnt-skip.html stable. r=#vt

Tweaking the columns property is causing a reframe which interrupts the
live capture. That's unrelated to what this test is checking tho.

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/00f6e459743f
https://hg.mozilla.org/integration/autoland/rev/7bb250d8b24f
Make column-span-during-transition-doesnt-skip.html stable. r=view-transitions-reviewers,boris

Comment 5

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Created web-platform-tests PR https://github.com/web-platform-tests/wpt/pull/53985 for changes under testing/web-platform/tests

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/a9a9f396f5c7
https://hg.mozilla.org/integration/autoland/rev/56f25225e91a
Revert "Bug 1978360 - Make column-span-during-transition-doesnt-skip.html stable. r=view-transitions-reviewers,boris" for causing WR failures

Comment 7

[Sandor Molnar[:smolnar]]

Backed out for causing WR failures

Backout link: https://hg.mozilla.org/integration/autoland/rev/56f25225e91a6e8d245dbe086935c41cf08a12a3

Push with failures

Failure log -> /css/css-view-transitions/column-span-during-transition-doesnt-skip.html

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/96666ecb794f
https://hg.mozilla.org/integration/autoland/rev/0a2d8d2aa122
Make column-span-during-transition-doesnt-skip.html stable. r=view-transitions-reviewers,boris

Comment 9

[Serban Stanca [:SerbanS]]

https://hg.mozilla.org/mozilla-central/rev/0a2d8d2aa122

Comment 10

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Upstream PR merged by moz-wptsync-bot