Closed Bug 1978364 Opened 26 days ago Closed 24 days ago

Allow pushing negative IntWord as immediate

Categories

(Core :: JavaScript Engine: JIT, enhancement, P1)

Product:
Core
Component:
JavaScript Engine: JIT
Type:
enhancement

Tracking

()

Status:
RESOLVED FIXED
Milestone:
143 Branch
Tracking Flags:
Tracking Status
firefox143 --- fixed

People

(Reporter: anba, Assigned: anba)

References

(Blocks 1 open bug)

Details

Attachments

(1 file)

Bug 1978364: Allow pushing negative IntWord as immediate. r=jandem!
48 bytes, text/x-phabricator-request
Details | Review

Assembler::push(ImmWord) only supports positive int32 as immediates, even though negative int32 are also valid.

This allows encoding push -1 without an extra mov.

Blocks: sm-jits
Severity: -- → N/A
Priority: -- → P1
Blocks: sm-masm
No longer blocks: sm-jits

https://hg.mozilla.org/mozilla-central/rev/ab2c3d0e28c4

Status: ASSIGNED → RESOLVED
Closed: 24 days ago
status-firefox143: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 143 Branch
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: