Closed Bug 1978494 Opened 9 months ago Closed 7 months ago

Support writing and reading cache metadata for Compression Dictionaries

Tracking

()

Status:

RESOLVED FIXED

Milestone:

145 Branch

Tracking Flags:

Tracking

Status

firefox145

---

fixed

People

(Reporter: jesup, Assigned: jesup)

References

Details

(Whiteboard: [necko-triaged])

Attachments

(4 files)

Bug 1978494: Read and write of per-origin compression dictionary cache entries/metadata r=#necko-reviewers! 9 months ago Randell Jesup [:jesup] (needinfo me) 48 bytes, text/x-phabricator-request		Details \| Review
Bug 1978494: Don't use stale dictionaries, more logs, improve handling of dictionary origin reading r=#necko-reviewers! 8 months ago Randell Jesup [:jesup] (needinfo me) 48 bytes, text/x-phabricator-request		Details \| Review
Bug 1978494: Fix GetOriginalHeader to account for new header type r=#necko-reviewers! 8 months ago Randell Jesup [:jesup] (needinfo me) 48 bytes, text/x-phabricator-request		Details \| Review
Bug 1978494: Make sure Suspend is called before we initiate async dictionary origin reader r=#necko-reviewers! 7 months ago Randell Jesup [:jesup] (needinfo me) 48 bytes, text/x-phabricator-request		Details \| Review

Randell Jesup [:jesup] (needinfo me)

Assignee

Description

•

9 months ago

We will store the data from Use-As-Dictionary as metadata in a dict:<origin> cache entries' metadata

Randell Jesup [:jesup] (needinfo me)

Assignee

Comment 1

•

9 months ago

Attached file Bug 1978494: Read and write of per-origin compression dictionary cache entries/metadata r=#necko-reviewers! — Details

edgul

Updated

•

9 months ago

Severity: -- → S3

Priority: -- → P2

Whiteboard: [necko-triaged]

Randell Jesup [:jesup] (needinfo me)

Assignee

Comment 2

•

8 months ago

Attached file Bug 1978494: Don't use stale dictionaries, more logs, improve handling of dictionary origin reading r=#necko-reviewers! — Details

Randell Jesup [:jesup] (needinfo me)

Assignee

Comment 3

•

8 months ago

Attached file Bug 1978494: Fix GetOriginalHeader to account for new header type r=#necko-reviewers! — Details

Pulsebot

Comment 4

•

7 months ago

Pushed by rjesup@mozilla.com: https://github.com/mozilla-firefox/firefox/commit/3ba403a61bd2 https://hg.mozilla.org/integration/autoland/rev/f1c0d6155b6e Read and write of per-origin compression dictionary cache entries/metadata r=necko-reviewers,valentin https://github.com/mozilla-firefox/firefox/commit/44958040fe7c https://hg.mozilla.org/integration/autoland/rev/7a64e644e863 Don't use stale dictionaries, more logs, improve handling of dictionary origin reading r=necko-reviewers,valentin https://github.com/mozilla-firefox/firefox/commit/5a5a9a09584a https://hg.mozilla.org/integration/autoland/rev/01805adc62db Fix GetOriginalHeader to account for new header type r=necko-reviewers,valentin

Sandor Molnar[:smolnar]

Comment 5

•

7 months ago

Backed out for causing multiple bustages/failures

Backout link: https://hg.mozilla.org/integration/autoland/rev/837a3d407e1c473641116eb9e1a150237c764645

Push with failures

Failure log -> TEST-UNEXPECTED-ERROR | /builds/worker/checkouts/gecko/netwerk/test/unit/test_dictionary_storage.js:595:9 | 'headerValue' is assigned a value but never used. (no-unused-vars)

Failure log -> ERROR - /builds/worker/checkouts/gecko/netwerk/streamconv/converters/nsHTTPCompressConv.cpp:358:23: error: format '%d' expects argument of type 'int', but argument 4 has type 'nsresult' [-Werror=format=]

Failure log -> ERROR - /builds/worker/workspace/obj-build/dist/include/mozilla/net/Dictionary.h:313:14: error: unused variable 'rv' [-Werror,-Wunused-variable]

Failure log -> TEST-UNEXPECTED-FAIL | netwerk/test/unit/test_trr.js | test_server_up - [test_server_up : 84] "undefined" == "Error: could not find id"

Failure log -> TEST-UNEXPECTED-FAIL | /service-workers/service-worker/worker-interception.https.html

Failure log -> TEST-UNEXPECTED-FAIL | devtools/client/netmonitor/test/browser_net_copy_headers.js | Timed out while polling clipboard for requested data

Flags: needinfo?(rjesup)

Cristian Tuns

Comment 6

•

7 months ago

bugherder

https://hg.mozilla.org/mozilla-central/rev/f1c0d6155b6e
https://hg.mozilla.org/mozilla-central/rev/7a64e644e863
https://hg.mozilla.org/mozilla-central/rev/01805adc62db

Status: NEW → RESOLVED

Closed: 7 months ago

status-firefox145: --- → fixed

Resolution: --- → FIXED

Target Milestone: --- → 145 Branch

Pulsebot

Comment 7

•

7 months ago

Pushed by rjesup@mozilla.com: https://github.com/mozilla-firefox/firefox/commit/335f2c9fbbb3 https://hg.mozilla.org/integration/autoland/rev/84d29f58b7c0 Read and write of per-origin compression dictionary cache entries/metadata r=necko-reviewers,valentin https://github.com/mozilla-firefox/firefox/commit/20e14f4d49b4 https://hg.mozilla.org/integration/autoland/rev/155e5357a48c Don't use stale dictionaries, more logs, improve handling of dictionary origin reading r=necko-reviewers,valentin https://github.com/mozilla-firefox/firefox/commit/b26eaba8f2ed https://hg.mozilla.org/integration/autoland/rev/d0b864c7927c Fix GetOriginalHeader to account for new header type r=necko-reviewers,valentin

amarc

Comment 8

•

7 months ago

Backed out for causing multiple failures

Status: RESOLVED → REOPENED

status-firefox145: fixed → ---

Resolution: FIXED → ---

Target Milestone: 145 Branch → ---

Pulsebot

Comment 9

•

7 months ago

Pushed by rjesup@mozilla.com: https://github.com/mozilla-firefox/firefox/commit/b9b9ce5b59b7 https://hg.mozilla.org/integration/autoland/rev/d788ded82870 Read and write of per-origin compression dictionary cache entries/metadata r=necko-reviewers,valentin

Pulsebot

Comment 10

•

7 months ago

Pushed by rjesup@mozilla.com: https://github.com/mozilla-firefox/firefox/commit/cf88b3debf72 https://hg.mozilla.org/integration/autoland/rev/3a9eea7a4ade Read and write of per-origin compression dictionary cache entries/metadata r=necko-reviewers,valentin https://github.com/mozilla-firefox/firefox/commit/e682425023db https://hg.mozilla.org/integration/autoland/rev/cfd200deeb80 Don't use stale dictionaries, more logs, improve handling of dictionary origin reading r=necko-reviewers,valentin https://github.com/mozilla-firefox/firefox/commit/e3673c58e0dd https://hg.mozilla.org/integration/autoland/rev/4377004f57ad Fix GetOriginalHeader to account for new header type r=necko-reviewers,valentin

Pulsebot

Comment 11

•

7 months ago

Pushed by rjesup@mozilla.com: https://github.com/mozilla-firefox/firefox/commit/eb6c1926577d https://hg.mozilla.org/integration/autoland/rev/f335d95bb178 Read and write of per-origin compression dictionary cache entries/metadata r=necko-reviewers,valentin https://github.com/mozilla-firefox/firefox/commit/08db8b11eb15 https://hg.mozilla.org/integration/autoland/rev/e9fb545515ad Don't use stale dictionaries, more logs, improve handling of dictionary origin reading r=necko-reviewers,valentin https://github.com/mozilla-firefox/firefox/commit/15b1e288ee49 https://hg.mozilla.org/integration/autoland/rev/48f2c85ecf59 Fix GetOriginalHeader to account for new header type r=necko-reviewers,valentin

Cristian Tuns

Comment 12

•

7 months ago

bugherder

https://hg.mozilla.org/mozilla-central/rev/f335d95bb178
https://hg.mozilla.org/mozilla-central/rev/e9fb545515ad
https://hg.mozilla.org/mozilla-central/rev/48f2c85ecf59

Status: REOPENED → RESOLVED

Closed: 7 months ago → 7 months ago

status-firefox145: --- → fixed

Resolution: --- → FIXED

Target Milestone: --- → 145 Branch

Atila Butkovits

Comment 13

•

7 months ago

Backed out for causing failures /dictionary-compressed.tentative.https.html.

Backout link: https://hg-edge.mozilla.org/integration/autoland/rev/339cb96b8aea9a433abdfee35eca4472ecb7074e

Push where failures started: https://treeherder.mozilla.org/jobs?repo=autoland&searchStr=windows%2C11%2Cx86%2C24h2%2Copt%2Cweb%2Cplatform%2Ctests%2Ctest-windows11-32-24h2%2Fopt-web-platform-tests%2Cwpt12&revision=f63dea815067f6fefbac80cce46e1a0589f66a31&selectedTaskRun=OXPZFu52Tyq66R0qicmggw.0

Failure log: https://treeherder.mozilla.org/logviewer?job_id=529651894&repo=autoland&task=OXPZFu52Tyq66R0qicmggw.0&lineNumber=10724

Status: RESOLVED → REOPENED

status-firefox145: fixed → ---

Resolution: FIXED → ---

Target Milestone: 145 Branch → ---

Randell Jesup [:jesup] (needinfo me)

Assignee

Comment 14

•

7 months ago

Attached file Bug 1978494: Make sure Suspend is called before we initiate async dictionary origin reader r=#necko-reviewers! — Details

Pulsebot

Comment 15

•

7 months ago

Pushed by rjesup@mozilla.com: https://github.com/mozilla-firefox/firefox/commit/32fb24708cfb https://hg.mozilla.org/integration/autoland/rev/a279f37c137f Read and write of per-origin compression dictionary cache entries/metadata r=necko-reviewers,valentin https://github.com/mozilla-firefox/firefox/commit/a2c00deb4d2d https://hg.mozilla.org/integration/autoland/rev/e5938c888f18 Don't use stale dictionaries, more logs, improve handling of dictionary origin reading r=necko-reviewers,valentin https://github.com/mozilla-firefox/firefox/commit/0939a45626b6 https://hg.mozilla.org/integration/autoland/rev/fa8a84766ffe Fix GetOriginalHeader to account for new header type r=necko-reviewers,valentin https://github.com/mozilla-firefox/firefox/commit/26c4a68ff792 https://hg.mozilla.org/integration/autoland/rev/7afcd0da5ae9 Make sure Suspend is called before we initiate async dictionary origin reader r=necko-reviewers,valentin

Pulsebot

Comment 16

•

7 months ago

Pushed by rjesup@mozilla.com: https://github.com/mozilla-firefox/firefox/commit/0b4eb92e4ae0 https://hg.mozilla.org/integration/autoland/rev/5ec56a8e5baf Read and write of per-origin compression dictionary cache entries/metadata r=necko-reviewers,valentin https://github.com/mozilla-firefox/firefox/commit/e0dc9ce060fe https://hg.mozilla.org/integration/autoland/rev/c88a923c8256 Don't use stale dictionaries, more logs, improve handling of dictionary origin reading r=necko-reviewers,valentin https://github.com/mozilla-firefox/firefox/commit/d2045d0657f5 https://hg.mozilla.org/integration/autoland/rev/51c544ea3fad Fix GetOriginalHeader to account for new header type r=necko-reviewers,valentin https://github.com/mozilla-firefox/firefox/commit/d7b30508f227 https://hg.mozilla.org/integration/autoland/rev/1fcf5c07babe Make sure Suspend is called before we initiate async dictionary origin reader r=necko-reviewers,valentin

pstanciu

Comment 17

•

7 months ago

bugherder

https://hg.mozilla.org/mozilla-central/rev/5ec56a8e5baf
https://hg.mozilla.org/mozilla-central/rev/c88a923c8256
https://hg.mozilla.org/mozilla-central/rev/51c544ea3fad
https://hg.mozilla.org/mozilla-central/rev/1fcf5c07babe

Status: REOPENED → RESOLVED

Closed: 7 months ago → 7 months ago

status-firefox145: --- → fixed

Resolution: --- → FIXED

Target Milestone: --- → 145 Branch

Randell Jesup [:jesup] (needinfo me)

Assignee

Updated

•

7 months ago

Flags: needinfo?(rjesup)

Mihai Boldan, Desktop QA [:mboldan]

Updated

•

7 months ago

QA Whiteboard: [qa-triage-done-c146/b145]

You need to log in before you can comment on or make changes to this bug.