1978519 - Text in the crash reporter dialog is not localized for the non-US FF builds

Status: VERIFIED FIXED

(Toolkit :: Crash Reporting, defect)

Description

[Alexandru Trif, Desktop Test Engineering [:atrif]]

Found in

• 142.0b1

Affected versions

• 143.0a1 (2025-07-21)
• 142.0b1

Tested platforms

• Affected platforms: macOS 15 aarch, Ubuntu 24, Windows 11/10
• Unaffected platforms: none

Preconditions

• Have a localized build downloaded, e.g. "it", "fr" or "de".

Steps to reproduce

1. Go to "about:crashparent" in a new tab.
2. Pay attention to the text inside the crash reporter dialog

Expected result

• The text inside the crash reporter dialog is accordingly translated to the tested build ("it", "fr" or "de").

Actual result

• The text inside the crash reporter dialog is not translated to the tested build ("it", "fr" or "de").

Regression range

• Last good build: https://archive.mozilla.org/pub/firefox/nightly/2025/07/2025-07-04-09-11-29-mozilla-central-l10n/
• First bad build: https://archive.mozilla.org/pub/firefox/nightly/2025/07/2025-07-04-21-20-32-mozilla-central-l10n/
• Manual pushlog: https://hg-edge.mozilla.org/integration/autoland/pushloghtml?fromchange=a6f7315f4ebdc0c5a1c8d2a5dba5657a0b80f94e&tochange=e9b77924bb503e2f75515954e550ff7cbb6a3837
• Potential regressor: Bug 1964600. Please change it if you feel otherwise. Thank you!

Comment 1

[BugBot [:suhaib / :marco]]

:gsvelto, since you are the author of the regressor, bug 1964600, could you take a look? Also, could you set the severity field?

For more information, please visit BugBot documentation.

Comment 2

[Gabriele Svelto [:gsvelto]]

Alex, could you investigate this? I don't think it's because of bug 1964600 given it touches unrelated code. The pushlog contains an update to the fluent crates though (bug 1959777) and the version used by the crash reporter client has been bumped from 0.16.0 to 0.17.0. Maybe that's what's causing the issue?

Comment 3

[Alex Franchuk [:afranchuk]]

I'm seeing

[ERROR crashreporter::lang] failed to read localization data from the omnijar (failed to read zip archive in ./omni.ja: invalid Zip archive: Could not find EOCD)

So this seems related to bug 1975416.

Comment 4

[Alex Franchuk [:afranchuk]]

The regression was introduced by https://github.com/zip-rs/zip2/pull/247. I wish people were required to give a reason when yanking crate versions. I can't find why 2.1.3 was yanked (which is what prompted the update in the regressing bug).

Comment 5

[Alex Franchuk [:afranchuk]]

Actually the logic causing problems was introduced in https://github.com/zip-rs/zip2/commit/4065f0501f97865f75ae459664c065e2b07b8828#diff-f5613ff66dd29a0567e4173ff7c04ed28b08eb7384040946dd410698700b87eeR1130-R1132 (just after 2.1.3).

Comment 6

[Alex Franchuk [:afranchuk]]

I've created https://github.com/zip-rs/zip2/issues/384 upstream, and will create a patch of zip in our vendored version in the meantime.

Comment 7

[Alex Franchuk [:afranchuk]]

Attachment: Bug 1978519 - Add a test to ensure the crashreporter can read the omnijar r=gsvelto

Comment 8

[Alex Franchuk [:afranchuk]]

Attachment: Bug 1978519 - Patch the zip crate to allow reading omnijars r=gsvelto

This will hopefully be addressed upstream in
https://github.com/zip-rs/zip2/issues/384.

Comment 9

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/f528949fdbc7
https://hg.mozilla.org/integration/autoland/rev/488bb7078277
Add a test to ensure the crashreporter can read the omnijar r=gsvelto
https://github.com/mozilla-firefox/firefox/commit/fca9a995cbd4
https://hg.mozilla.org/integration/autoland/rev/e48e3e9bd34a
Patch the zip crate to allow reading omnijars r=gsvelto

Comment 10

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/0413d489221d
https://hg.mozilla.org/integration/autoland/rev/6c2ebe6bac67
Revert "Bug 1978519 - Patch the zip crate to allow reading omnijars r=gsvelto" for causing xpc failures @ test_crashreporter_omnijar_loading.js

Comment 11

[Sandor Molnar[:smolnar]]

Backed out for causing xpc failures @ test_crashreporter_omnijar_loading.js

Backout link: https://hg.mozilla.org/integration/autoland/rev/6c2ebe6bac6707ed14386d7c4851eaa1c03e7f38

Push with failures

Failure log -> TEST-UNEXPECTED-FAIL | toolkit/crashreporter/client/app/tests/xpcshell/test_crashreporter_omnijar_loading.js

Comment 12

[Alex Franchuk [:afranchuk]]

Ah whoops, I forgot that I intended for the new test to only run on linux (just as a matter of simplifying the test itself), since the loading of the omnijar shouldn't rely on the platform. :gsvelto do you think that would be okay, or should I run it on all platforms (which would require extra brittle code to get the correct path for the crashreporter)?

Comment 13

[Gabriele Svelto [:gsvelto]]

Linux only is fine for me. Just open a low-priority follow-up to enable it on other platforms too.

Comment 14

[Alex Franchuk [:afranchuk]]

I realized this is easy if I just put the test with the other crashreporter tests, where we already have a single function to get the crashreporter client path, so I did that.

Comment 15

[Dianna Smith [:diannaS]]

As a reminder we are in the last week of betas if we intend to fix this for 142.

Comment 16

[Alex Franchuk [:afranchuk]]

Thanks for the reminder; I'm landing it now.

Comment 17

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/c0f4054b0662
https://hg.mozilla.org/integration/autoland/rev/f0101b661d35
Add a test to ensure the crashreporter can read the omnijar r=gsvelto
https://github.com/mozilla-firefox/firefox/commit/400b6ea684cd
https://hg.mozilla.org/integration/autoland/rev/c526a1730a5a
Patch the zip crate to allow reading omnijars r=gsvelto

Comment 18

[Cristina Horotan [:chorotan]]

https://hg.mozilla.org/mozilla-central/rev/f0101b661d35
https://hg.mozilla.org/mozilla-central/rev/c526a1730a5a

Comment 19

[BugBot [:suhaib / :marco]]

The patch landed in nightly and beta is affected.
:afranchuk, is this bug important enough to require an uplift?

• If yes, please nominate the patch for beta approval.
  • See https://wiki.mozilla.org/Release_Management/Requesting_an_Uplift for documentation on how to request an uplift.
• If no, please set status-firefox142 to wontfix.

For more information, please visit BugBot documentation.

Comment 20

[Alex Franchuk [:afranchuk]]

Attachment: Bug 1978519 - Add a test to ensure the crashreporter can read the omnijar

Original Revision: https://phabricator.services.mozilla.com/D259199

Comment 21

[Alex Franchuk [:afranchuk]]

Attachment: Bug 1978519 - Patch the zip crate to allow reading omnijars

This will hopefully be addressed upstream in
https://github.com/zip-rs/zip2/issues/384.

Original Revision: https://phabricator.services.mozilla.com/D259200

Comment 22

[Phabricator Automation]

firefox-beta Uplift Approval Request

• User impact if declined: Incorrect localization in the crash reporter client
• Code covered by automated testing: yes
• Fix verified in Nightly: yes
• Needs manual QE test: yes
• Steps to reproduce for manual QE testing: Install a non-en-US firefox. Navigate to about:crashparent. Verify the crash reporter client comes up with the installed locale.
• Risk associated with taking this patch: Low
• Explanation of risk level: This is a minor patch to the zip crate to support loading the omnijar from the crash reporter client. No other code uses the zip crate in our repository.
• String changes made/needed: No
• Is Android affected?: no

Comment 23

[Pulsebot]

https://github.com/mozilla-firefox/firefox/commit/0873c4e65180
https://hg.mozilla.org/releases/mozilla-beta/rev/0d12fe4af9d0
https://github.com/mozilla-firefox/firefox/commit/c7bfa95acdc4
https://hg.mozilla.org/releases/mozilla-beta/rev/89f263ba293f

Comment 24

[Alexandru Trif, Desktop Test Engineering [:atrif]]

Verified fixed with Firefox 143.0a1 (2025-08-05) on Windows 10x64, macOS 14 and Ubuntu 24. The crash reporter is localized when using localized builds.

Comment 25

[Alexandru Trif, Desktop Test Engineering [:atrif]]

Verified fixed with Firefox 142.0b8 on Windows 10x64, macOS 12 and Ubuntu 24. The crash reporter is localized when using localized builds.