Closed Bug 1978522 Opened 20 days ago Closed 13 days ago

[wpt-sync] Sync PR 53884 - Optimize keyboard focusable for the radio element

Categories

(Core :: DOM: Core & HTML, task, P4)

Product:
Core
Component:
DOM: Core & HTML
Type:
task

Tracking

()

Status:
RESOLVED FIXED
Milestone:
143 Branch
Tracking Flags:
Tracking Status
firefox143 --- fixed

People

(Reporter: wpt-sync, Unassigned)

References

(
URL
)

Details

(Whiteboard: [wptsync downstream])

Sync web-platform-tests PR 53884 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/53884
Details from upstream follow.

zhoupeng <zhoupeng.1996@bytedance.com> wrote:

Optimize keyboard focusable for the radio element

Optimize keyboard focusable for the radio button. Making the focus
navigation of the radio group more reasonable and consistent with the
Firefox. The focus navigation behavior:

  • If any radio button in the group is checked, tab navigation always
    focuses the checked button, regardless of the group's current focus
    state.
  • When focus is on a radio button in the group, tab navigation skips the
    remaining buttons in the group.
  • Both forward and backward tab navigation target the first
    radio button in the group when entering the group.

Bug: 421837104
Change-Id: I8b4a984f65b8eaa47aa6e2973a3af1e27c96ad06
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6703466
Reviewed-by: Mason Freed \<masonf@chromium.org>
Commit-Queue: Peng Zhou \<zhoupeng.1996@bytedance.com>
Cr-Commit-Position: refs/heads/main@{#1489938}

Component: web-platform-tests → DOM: Core & HTML
Product: Testing → Core

CI Results

Ran 9 Firefox configurations based on mozilla-central, and Firefox, Chrome, and Safari on GitHub CI

Total 4 tests and 2 subtests

Status Summary

Firefox

OK : 4
PASS: 9

Chrome

OK : 4
PASS: 3
FAIL: 6

Safari

OK : 4
PASS: 1
FAIL: 8

Links

Gecko CI (Treeherder)
GitHub PR Head
GitHub PR Base

The changes in Sync PR 53884 – Optimize keyboard focusable for the radio element look good to me. This should help improve accessibility and focus behavior as intended.

LGTM 👍 — feel free to land after addressing any pending CI results.

Spider Clothing
Spider Hoodie

https://hg.mozilla.org/mozilla-central/rev/7421042c6149
https://hg.mozilla.org/mozilla-central/rev/48b0a559cccf

Status: NEW → RESOLVED
Closed: 13 days ago
status-firefox143: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 143 Branch
You need to log in before you can comment on or make changes to this bug.