1978542 - When using DoH, DNS cache entries are unexpectedly cleared after network change

Status: RESOLVED FIXED

(Core :: Networking: DNS, defect, P2)

Description

[Kershaw Chang [:kershaw]]

When the network changes, we call FlushCache to purge DNS cache entries that were not resolved via DoH (aTrrToo is false). The rationale is that DoH responses come from a remote TRR server, so there’s no need to clear them when the user switches networks.

However, we currently call FlushEvictionQ here, which effectively removes the entry from the cache database. As a result, DNS cache entries are being cleared unexpectedly.

Comment 1

[Kershaw Chang [:kershaw]]

Attachment: Bug 1978542 - Don't flush eviction queue when netowrk changed, r=#necko

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/9ab209c7ab8f
https://hg.mozilla.org/integration/autoland/rev/c1b4ea2abcab
Don't flush eviction queue when netowrk changed, r=necko-reviewers,jesup

Comment 3

[Cristian Tuns]

https://hg.mozilla.org/mozilla-central/rev/c1b4ea2abcab