1978549 - Normal tabs are displayed under the Private Section and vice versa in Tabs Tray

Status: RESOLVED FIXED

(Firefox for Android :: Tabs, defect)

Description

[Vasilica Tamas (Android QA) [:vtamas]]

Attachment: SwitchedTabsTraySections.mp4

Steps to reproduce

1. Open a tab in normal browsing and one in private browsing.
2. Open the Tabs Tray and check in which sections are the tabs displayed.
3. Switch between the normal and private sections.

Expected behavior

The website opened in normal browsing is displayed in normal tabs section and the private tab in private section.

Actual behavior

• The website opened in normal browsing appears in the Private tabs section and vice versa.
• Selecting the Normal section focuses the Private one and vice versa.

Device information

• Firefox version: Firefox for Android 142 beta 1
• Android device model: Google Pixel 8 (Android 16) and Samsung S24 Ultra (Android 15)

Comment 1

[Noah Bond [:007]]

Attachment: Bug 1978549 - Ensure the Tabs Tray banner displays the correct active tab page button

Comment 2

[Noah Bond [:007]]

Attachment: Bug 1978549 - Ensure the Tabs Tray banner displays the correct active tab page button

Original Revision: https://phabricator.services.mozilla.com/D258294

Comment 3

[Noah Bond [:007]]

Approval Request Comment
[Feature/Bug causing the regression]: Tabs Tray redesign, Bug 1971403
[User impact if declined]: Users will have a bugged experience causing the Normal and Private tabs tray buttons to be flipped.
[Is this code covered by automated tests?]: Yes
[Has the fix been verified in Nightly?]: No
[Needs manual test from QE? If yes, steps to reproduce]: Yes
[List of other uplifts needed for the feature/fix]: N/A
[Is the change risky?]: No
[Why is the change risky/not risky?]: This was a minimal code change.
[String changes made/needed]: N/A

Comment 4

[Phabricator Automation]

firefox-beta Uplift Approval Request

• User impact if declined: Users will have a bugged experience causing the Normal and Private tabs tray buttons to be flipped. [Is this code covered by automated tests?]: Yes
• Code covered by automated testing: yes
• Fix verified in Nightly: no
• Needs manual QE test: yes
• Steps to reproduce for manual QE testing: see comment 0
• Risk associated with taking this patch: Low
• Explanation of risk level: This was a minimal code change.
• String changes made/needed: None
• Is Android affected?: yes

Comment 5

[Pulsebot]

https://github.com/mozilla-firefox/firefox/commit/aa3ce6bba533
https://hg.mozilla.org/releases/mozilla-beta/rev/e565d8a7f4d4

Comment 6

[Vasilica Tamas (Android QA) [:vtamas]]

Attachment: TabsTraySections.mp4

This issue is verified as fixed on Firefox for Android 142 beta 2 on Samsung S24 Ultra (Android 15) and Google Pixel 8 (Android 16). Confirming that each tab is displayed under the correct section.

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/286d22197a0e
https://hg.mozilla.org/integration/autoland/rev/7049ed926be0
Ensure the Tabs Tray banner displays the correct active tab page button r=calu,android-reviewers

Comment 8

[Atila Butkovits]

https://hg.mozilla.org/mozilla-central/rev/7049ed926be0