1978596 - [composable toolbar] Configure availability depending on Nimbus

Status: RESOLVED FIXED

(Firefox for Android :: Toolbar, task, P2)

Description

[Petru-Mugurel Lingurar [:petru]]

The composable toolbar should be made available to users through a staged rollout process.
The Nimbus experiment will initially target only Nightly users.
The experiment name will be composable-toolbar.

Comment 1

[Petru-Mugurel Lingurar [:petru]]

Attachment: Bug 1978596 - part 1 - Setup composable toolbar availability r=#android-reviewers

It will be enabled by default on debug builds while being disabled
on other build types and in UI tests.
The availability in production will be controllable through Nimbus.

Comment 2

[Michel Le Bihan]

Since there are still known unfixed issues with the composable toolbar and several proposed patches to the old toolbar, wouldn't it make sense to postpone that change to 144?

Comment 3

[Petru-Mugurel Lingurar [:petru]]

(In reply to Michel Le Bihan from comment #2)

Since there are still known unfixed issues with the composable toolbar and several proposed patches to the old toolbar, wouldn't it make sense to postpone that change to 144?

What "still known unfixed issues with the composable toolbar" are you referring at?
While we did fix some the primary goal of the composable toolbar project is not to fix the current issues but rather adopt the current architecture we want for the application with the later goal to support easier feature developments and bug fixes.

Comment 4

[Petru-Mugurel Lingurar [:petru]]

Attachment: Bug 1978596 - part 2 - Use both toolbar view and composable toolbar in baseline profiles CUJs r=#android-reviewers

Since the composable toolbar is launched gradually there will be a period in which
the same application version might use either of the toolbar view or the composable
toolbar and so the tests generating baseline profiles must account for both toolbars
to ensure a smooth UI no matter which toolbar is used.

Comment 5

[Michel Le Bihan]

I thought about issues like bug 1980777 and the composable toolbar variant of bug 1979534.

Comment 6

[Petru-Mugurel Lingurar [:petru]]

(In reply to Michel Le Bihan from comment #5)

I thought about issues like bug 1980777 and the composable toolbar variant of bug 1979534.

Thank you!
The first seems to be a Jetpack Compose bug that will need more investigation but doesn't seem like a blocker.
I'll put up a patch for bug 1979534 soon so that the changes for both the toolbar view and composable toolbar land at the same time to ensure feature parity.

Comment 7

[Petru-Mugurel Lingurar [:petru]]

Attachment: Bug 1978596 - part 3 - Update macrobenchmark parsing script to support the new test names r=#android-reviewers

With using parameterized tests the test names will contain the parameter and so
the previous assumption that some tests can end in None will not hold in all
cases anymore as now we can have privateBrowsingNone[composableToolbar=false].

Moved to a more flexible approach of removing the None part from test names
which will allow building the results table with support for more test names.

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/4984e9719fc8
https://hg.mozilla.org/integration/autoland/rev/f254c933c95a
part 1 - Setup composable toolbar availability r=android-reviewers,Roger
https://github.com/mozilla-firefox/firefox/commit/588a7aac6199
https://hg.mozilla.org/integration/autoland/rev/cd0f96298bd1
part 2 - Use both toolbar view and composable toolbar in baseline profiles CUJs r=android-reviewers,tthibaud,npoon
https://github.com/mozilla-firefox/firefox/commit/2b51aea523d6
https://hg.mozilla.org/integration/autoland/rev/096add3d39a1
part 3 - Update macrobenchmark parsing script to support the new test names r=android-reviewers,npoon,tthibaud

Comment 9

[Sandor Molnar[:smolnar]]

https://hg.mozilla.org/mozilla-central/rev/f254c933c95a
https://hg.mozilla.org/mozilla-central/rev/cd0f96298bd1
https://hg.mozilla.org/mozilla-central/rev/096add3d39a1