1978620 - firefox-141.0 doesn't start if gtk+ doesn't have wayland support

Status: RESOLVED FIXED

(Core :: Widget: Gtk, defect)

Description

[Joonas Niilola]

Steps to reproduce:

Download latest Firefox-141.0 for Linux from https://archive.mozilla.org/pub/firefox/releases/141.0/linux-x86_64/en-US/
extract and run it.

Actual results:

$ ./firefox-bin 
XPCOMGlueLoad error for file /home/gui/ff/firefox/libxul.so:
/home/gui/ff/firefox/libxul.so: undefined symbol: gdk_wayland_device_get_wl_seat
Couldn't load XPCOM.

When the system gtk+ package is built without wayland support.
gtk+ still has an option to disable wayland,
https://gitlab.gnome.org/GNOME/gtk/-/blob/main/meson.options?ref_type=heads#L12

option('wayland-backend',
       type: 'boolean',
       value: true,
       description : 'Enable the wayland gdk backend (only when building on Unix except for macOS)')

Expected results:

Firefox should launch using X11 backend instead. The previous versions had no issues with this.
--enable-default-toolkit=cairo-gtk3-x11-wayland has worked previously just fine even without wayland backend in gtk+?

Comment 1

[BugBot [:suhaib / :marco]]

The Bugbug bot thinks this bug should belong to the 'Core::Widget: Gtk' component, and is moving the bug to that component. Please correct in case you think the bot is wrong.

Comment 2

[Thinker Li [:sinker]]

Emilio, do you have any idea?
Looks like that we need a weak symbol here.

Comment 3

[Emilio Cobos Álvarez [:emilio]]

Attachment: Bug 1978620 - Add gdk_wayland_device_get_wl_seat to mozwayland. r=stransky

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/b521b4d4766d
https://hg.mozilla.org/integration/autoland/rev/03126ea2d55a
Add gdk_wayland_device_get_wl_seat to mozwayland. r=stransky

Comment 5

[Cristina Horotan [:chorotan]]

https://hg.mozilla.org/mozilla-central/rev/03126ea2d55a

Comment 6

[Joonas Niilola]

Hey,

the patch applies to 141.0 and therefore was easy to test. Unfortunately I still couldn't get the browser to launch with this, when self-built with both X and wayland support and moved to a system where gtk+ doesn't have wayland support. 140.0.4 still seems to work fine with the test setup.

Anyway if there are more commits related to this that'll make it work, could these be backported to a .1 release, or at least to upcoming 142?

Comment 7

[Emilio Cobos Álvarez [:emilio]]

Unfortunately I still couldn't get the browser to launch with this

What is the error? I can try to somehow get a setup with x11-only GTK3 next week I guess. Thanks

Comment 8

[Joonas Niilola]

Indeed the error is slightly different now:

$ firefox 
XPCOMGlueLoad error for file /usr/lib64/firefox/libxul.so:
/usr/lib64/firefox/libxul.so: undefined symbol: gdk_wayland_window_set_use_custom_surface
Couldn't load XPCOM.

Comment 9

[Emilio Cobos Álvarez [:emilio]]

Ok, that's another new function call that I missed. can you confirm this diff fixes it for you? I think it's the last :)

diff --git a/widget/gtk/mozwayland/mozwayland.c b/widget/gtk/mozwayland/mozwayland.c
index 28ddaa29625e..4fdc86f145a9 100644
--- a/widget/gtk/mozwayland/mozwayland.c
+++ b/widget/gtk/mozwayland/mozwayland.c
@@ -226,6 +226,9 @@ MOZ_EXPORT struct wl_surface* gdk_wayland_window_get_wl_surface(
   return NULL;
 }

+MOZ_EXPORT void gdk_wayland_window_set_use_custom_surface(
+    GdkWaylandWindow* window) {}
+
 MOZ_EXPORT struct wl_pointer* gdk_wayland_device_get_wl_pointer(
     GdkDevice* device) {
   return NULL;

Comment 10

[Joonas Niilola]

Now it works! :)

Thanks! Could these be backported to the next release?

(also reopening until the commit lands to the source tree and this bug can be referenced)

Comment 11

[Emilio Cobos Álvarez [:emilio]]

Attachment: Bug 1978620 - Add gdk_wayland_window_set_use_custom_surface to mozwayland too. r=stransky

Comment 12

[Emilio Cobos Álvarez [:emilio]]

Comment on attachment 9503237 [details]
Bug 1978620 - Add gdk_wayland_window_set_use_custom_surface to mozwayland too. r=stransky

Beta/Release Uplift Approval Request

• User impact if declined/Reason for urgency: Fixes startup on some uncommon setups.
• Is this code covered by automated tests?: No
• Has the fix been verified in Nightly?: Yes
• Needs manual test from QE?: No
• If yes, steps to reproduce:
• List of other uplifts needed: none
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): ~zero risk, defines some symbols that are otherwise replaced for the real ones.
• String changes made/needed: none
• Is Android affected?: No

Comment 13

[Emilio Cobos Álvarez [:emilio]]

Comment on attachment 9502291 [details]
Bug 1978620 - Add gdk_wayland_device_get_wl_seat to mozwayland. r=stransky

(See above)

Comment 14

[BugBot [:suhaib / :marco]]

Set release status flags based on info from the regressing bug 1970372

Comment 15

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/4fb3303c0f41
https://hg.mozilla.org/integration/autoland/rev/17b54f5b1ec5
Add gdk_wayland_window_set_use_custom_surface to mozwayland too. r=stransky

Comment 16

[Pascal Chevrel (relman team) -> :pascalc]

Tracking for next week planned dot release.

Comment 17

[Cristian Tuns]

https://hg.mozilla.org/mozilla-central/rev/17b54f5b1ec5

Comment 18

[Dianna Smith [:diannaS]]

Comment on attachment 9502291 [details]
Bug 1978620 - Add gdk_wayland_device_get_wl_seat to mozwayland. r=stransky

Approved for 142.0b5 and 142.0b6

Comment 19

[Pulsebot]

https://github.com/mozilla-firefox/firefox/commit/469dfc408a11
https://hg.mozilla.org/releases/mozilla-beta/rev/ecad4eaf1ae5

Comment 20

[Emilio Cobos Álvarez [:emilio]]

Dianna, you only merged one of the two patches, right? https://hg.mozilla.org/mozilla-central/rev/03126ea2d55a is also needed

Comment 21

[Dianna Smith [:diannaS]]

hmm my apologies not sure how i missed that

Comment 22

[Pulsebot]

https://github.com/mozilla-firefox/firefox/commit/ea9b68fa8219
https://hg.mozilla.org/releases/mozilla-beta/rev/b0d08026f669

Comment 23

[Pulsebot]

https://github.com/mozilla-firefox/firefox/commit/cb84e1dec4ea
https://hg.mozilla.org/releases/mozilla-release/rev/8c7bff7daeb1
https://github.com/mozilla-firefox/firefox/commit/57962dd30d85
https://hg.mozilla.org/releases/mozilla-release/rev/ece9073afe71