1978641 - Update about:memory accounting for wasm GC objects

Status: RESOLVED FIXED

(Core :: JavaScript: WebAssembly, task, P1)

Description

[Ryan Hunt [:rhunt]]

From bug 1814520 I discovered we did not update some memory accounting routines for wasm GC objects. This would impact about:memory and also using the profiler to track allocation sizes.

[1] https://searchfox.org/mozilla-central/rev/387160feb07b75ae76bfc12df035a10f58d25168/js/src/vm/JSObject.cpp#3274
[2] https://searchfox.org/mozilla-central/rev/387160feb07b75ae76bfc12df035a10f58d25168/js/src/vm/JSObject.cpp#3209

Comment 1

[Ryan Hunt [:rhunt]]

These are both called from here [1] which is what is used for the profiler allocation sizes tracking code here [2].

[1] https://searchfox.org/mozilla-central/rev/387160feb07b75ae76bfc12df035a10f58d25168/js/src/vm/JSObject.cpp#3305-3311
[2] https://searchfox.org/mozilla-central/rev/387160feb07b75ae76bfc12df035a10f58d25168/js/src/vm/SavedStacks.cpp#2011

Comment 2

[Ben Visness [:bvisness]]

Attachment: Bug 1978641: Add about:memory reporting for wasm GC. r=rhunt

The size of WASM GC structs and arrays is now accounted for in
about:memory, for both nursery and tenured objects. This makes JS
allocation profiles much more useful.

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/f0aec1305685
https://hg.mozilla.org/integration/autoland/rev/0eb2dd3a4892
Add about:memory reporting for wasm GC. r=rhunt

Comment 4

[Sandor Molnar[:smolnar]]

https://hg.mozilla.org/mozilla-central/rev/0eb2dd3a4892