1978673 - The demo 3D image on canvas can sometimes be dragable.

Status: RESOLVED FIXED

(Core :: DOM: Selection, defect)

Description

[Alice0775 White]

STR:

1. Open https://kdata1.com/2019/11/97568/
2. Drag 3D image with mouse pointer

AR:
Sometimes, The image is actually dragable, and drag-image is displayed.
Screencast: https://youtu.be/9aEgdhkOW7c

ER:
The image rotates in 3D, but the image should not be dragable.

Regression window:
https://hg-edge.mozilla.org/integration/autoland/pushloghtml?fromchange=584aadc4313965c02a9d0a6b637714d3f812f4b2&tochange=ca42e3a0e39ccea55a166c68f47e7c53c526d3e9

FYI, Bug 1972967 does not fix this case.

Comment 1

[Alice0775 White]

:dmeehan,

In order to clarify the chronology of the problem occurrence,

Before Bug 1969829: no issue
After Bug 1969829: The canvas area becomes blue-gray, and the 3D object becomes blue and it becomes draggable.

Before Bug 1972967: same as the above
After Bug 1972967: the 3D object becomes draggable.

And, interestingly, this issue cannot be reproduced in Firefox 140 and 140esr.

Comment 2

[Donal Meehan [:dmeehan]]

Thanks Alice for the extra info!

Comment 3

[Tom Schuster (MoCo)]

This makes https://shapecatcher.com/ basically unusable.

Comment 4

[Tom Schuster (MoCo)]

[Tracking Requested - why for this release]: Makes it impossible to use some canvas based applications.

Comment 7

[johannes.welsch]

I provided the temporary fix here (CSS select non):
https://bugzilla.mozilla.org/show_bug.cgi?id=1979606

The severety is very high though! Every single app on the internet using 3D canvas is very likely broken right now. I have also tested a few apps that I know are using react-three/fiber and they're broken too.

Comment 8

[Emilio Cobos Álvarez (:emilio)]

I'm looking at this. Short term fix is probably just reintroducing the user-select rule...

Comment 9

[Alice0775 White]

(In reply to Tom Schuster (MoCo) from comment #3)

This makes https://shapecatcher.com/ basically unusable.

I can repro.
Screencast: https://youtu.be/Gbnr2x8vQSI

Comment 12

[Emilio Cobos Álvarez (:emilio)]

Attachment: Bug 1978673 - Prevent selection changes on HTML <canvas> elements. r=masayuki

I think this is the better fix, but for beta / release we should just
back out the regressing patch.

Comment 13

[Emilio Cobos Álvarez (:emilio)]

We should just back out the regressing patch from beta / release.

Comment 14

[Dianna Smith [:diannaS]]

:emilio Could you create a backout patch for this? There are two regressing bugs (one of which landed in 140) so might not be an easy backout.

Comment 15

[Emilio Cobos Álvarez (:emilio)]

Just reverting https://bugzilla.mozilla.org/attachment.cgi?id=9494680 should do.

Comment 16

[Mathew Hodson]

https://phabricator.services.mozilla.com/D253706 which seems to cause this wasn't uplifted in bug 1969829, so only Firefox 141 and later is affected.

Comment 17

[Dianna Smith [:diannaS]]

bug 1969829 patch https://phabricator.services.mozilla.com/D253706 is now reverted from 142.0b5
https://github.com/mozilla-firefox/firefox/commit/f18a70c3608c
https://hg.mozilla.org/releases/mozilla-beta/rev/1a1c782c259a
Revert "Bug 1969829 - Remove now unnecessary user-select override on <canvas>. r=masayuki,dshin" for causing bug 1978673 a=backout

Marking 142 as fixed by backout and adding NI for pascal in case he wants to backout of 141 for the dot release

Comment 18

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/20c2af5578a7
https://hg.mozilla.org/integration/autoland/rev/14c12122a580
Prevent selection changes on HTML <canvas> elements. r=masayuki,dom-core

Comment 19

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Created web-platform-tests PR https://github.com/web-platform-tests/wpt/pull/54049 for changes under testing/web-platform/tests

Comment 20

[Cristina Horotan [:chorotan]]

https://hg.mozilla.org/mozilla-central/rev/14c12122a580

Comment 21

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Upstream PR merged by moz-wptsync-bot

Comment 23

[Pascal Chevrel:pascalc]

Fixed in 141 by uplifting the backout
https://github.com/mozilla-firefox/firefox/commit/2d31f673efdc
https://hg.mozilla.org/releases/mozilla-release/rev/f318c7723a0a