1978676 - Translating message persists on Android even when Translations is not active

Status: RESOLVED FIXED

(Firefox for Android :: Toolbar, defect)

Description

[Erik Nordin [:nordzilla]]

Attachment: steps-to-reproduce.mp4

Description

Bug 1970084 removed the Translations button from the URL bar on Android and was uplifted into 140 release, which caused several regressions and side effects, including this one.

Thankfully, I think that Bug 1975878 fixes this issue, since I was unable to reproduce on Nightly. I am hoping that once that gets uplifted into the 141 dot release, that this behavior will be fixed.

I am currently able to reproduce in 141 and 142 beta, but not 143 Nightly.

Steps to reproduce

(See attached video for STR example)

1. Open a translatable page, e.g. https://ja.wikipedia.org/wiki/firefox.
2. Open the triple-dot menu and press the "Translate page" option.
3. Translate the page.
4. Before the bottom sheet closes automatically, press somewhere on the page to close it.

Expected behavior

The "Translating..." message bar should disappear when the models have fully loaded and begin translating.

Actual behavior

The "Translating..." message bar persists, even after pressing on links to go to other pages, at which point Translation is no longer occurring at all.

Comment 1

[Erik Nordin [:nordzilla]]

As mentioned in the description, I believe that this is fixed by Bug 1975878, but I've filed it separately so that it can be verified independently by QE.

Comment 2

[Olivia Hall [:olivia]]

Thanks for filing! Should have been fixed by bug 1976032.

Comment 3

[Olivia Hall [:olivia]]

Also, by bug 1976507. Where this is a binding issue, the issue had to be fixed in both the conventional and new compose toolbar.

Bug 1976032 was conventional.
Bug 1976507 was compose.

Comment 4

[Erik Nordin [:nordzilla]]

Thank you for the further context! I assumed it may have been fixed by Bug 1975878, but I think the bugs you linked are more correct.

Comment 5

[Olivia Hall [:olivia]]

I assumed it may have been fixed by Bug 1975878

One of the original patches was linked to Bug 1975878 and removed, when it was really meant for Bug 1976032, so definitely understandable.