1978688 - backgroundState is "running" instead of "stopped" when background page fails to load

Status: NEW

(Toolkit :: Add-ons Manager, defect, P3)

Description

[Rob Wu [:robwu]]

As part of being thorough, I added a new unit test in bug 1959339 that tests the behavior when a background page file does not exist.

The new test is at toolkit/components/extensions/test/xpcshell/test_ext_background_file_invalid.js
and revealed a strange bug: backgroundState is at state "running" instead of "stopped" (this state is reflected in about:debugging for example):

  if (WebExtensionPolicy.useRemoteWebExtensions) {
    // TODO: This is questionable - "stopped" would make more sense.
    // The current implementation detects the background load, because the
    // DOMContentLoaded event is fired right before the load navigates to an
    // error page.
    equal(extension.extension.backgroundState, "running", "backgroundState");
  } else {
    equal(extension.extension.backgroundState, "stopped", "backgroundState");
  }

Relevant fragment in Phabricator: https://phabricator.services.mozilla.com/D256910#inline-1414095