Closed Bug 1978715 Opened 5 months ago Closed 5 months ago

security/manager/ssl/SecretDecoderRing.cpp:140:7: error: use of undeclared identifier 'PK11SDR_EncryptWithMechanism'; did you mean 'PK11_VerifyWithMechanism'?

Categories

(Firefox Build System :: General, defect)

Product:
Firefox Build System
Component:
General
Type:
defect

Tracking

(Not tracked)

Status:
RESOLVED DUPLICATE of bug 1976767

People

(Reporter: glandium, Assigned: glandium)

References

(Regression)

Details

(Keywords: regression)

Building with --with-system-nss can fail with:

/build/firefox-141.0/security/manager/ssl/SecretDecoderRing.cpp:140:7: error: use of undeclared identifier 'PK11SDR_EncryptWithMechanism'; did you mean 'PK11_VerifyWithMechanism'?
  140 |   if (PK11SDR_EncryptWithMechanism(slot.get(), &keyid, type, &request, &reply,
      |       ^~~~~~~~~~~~~~~~~~~~~~~~~~~~
      |       PK11_VerifyWithMechanism
/usr/include/nss/pk11pub.h:816:11: note: 'PK11_VerifyWithMechanism' declared here
  816 | SECStatus PK11_VerifyWithMechanism(SECKEYPublicKey *key,
      |           ^
In file included from Unified_cpp_security_manager_ssl1.cpp:47:
/build/firefox-141.0/security/manager/ssl/SecretDecoderRing.cpp:140:36: error: cannot initialize a parameter of type 'SECKEYPublicKey *' (aka 'SECKEYPublicKeyStr *') with an rvalue of type 'pointer' (aka 'PK11SlotInfoStr *')
  140 |   if (PK11SDR_EncryptWithMechanism(slot.get(), &keyid, type, &request, &reply,
      |                                    ^~~~~~~~~~
/usr/include/nss/secmodt.h:32:16: note: 'PK11SlotInfoStr' is not defined, but forward declared here; conversion would be valid if it was derived from 'SECKEYPublicKeyStr'
   32 | typedef struct PK11SlotInfoStr PK11SlotInfo;          /* defined in secmodti.h */
      |                ^
/usr/include/nss/pk11pub.h:816:53: note: passing argument to parameter 'key' here
  816 | SECStatus PK11_VerifyWithMechanism(SECKEYPublicKey *key,
      |                                                     ^
2 errors generated.

The reason is that bug 198090 requires a new symbol from NSS 3.113 but build/moz.configure/nss.configure hasn't been updated to reflect that.

Well, this was fixed in 142 with bug 1976767 without a review from a build peer, and without an uplift to 141.

Status: NEW → RESOLVED
Closed: 5 months ago
Duplicate of bug: 1976767
Resolution: --- → DUPLICATE

that, and when bug 1976767 landed there was no actual nss/nspr releases available, so building m-c using --with-system-nss was broken.

You need to log in before you can comment on or make changes to this bug.