Closed
Bug 197877
Opened 21 years ago
Closed 21 years ago
PSM should upgrade to NSS 3.8.
Categories
(Core Graveyard :: Security: UI, defect)
Tracking
(Not tracked)
VERIFIED
FIXED
psm2.4
People
(Reporter: wtc, Assigned: KaiE)
References
Details
Attachments
(1 file, 2 obsolete files)
4.34 KB,
patch
|
KaiE
:
review+
bryner
:
superreview+
|
Details | Diff | Splinter Review |
PSM should upgrade to the upcoming NSS 3.8 release. We need to make at least two PSM changes. 1. PSM needs to build the new NSS tool "shlibsign" and generate the *.chk FIPS checksum files with it. 2. The new *.chk FIPS checksum files need to be installed in the appropriate directories and packaged in the GRE and Mozilla installers.
Reporter | ||
Updated•21 years ago
|
QA Contact: junruh → bmartin
Reporter | ||
Comment 1•21 years ago
|
||
This patch is incomplete. Still need to install and package the *.chk files.
Reporter | ||
Comment 2•21 years ago
|
||
I think this patch has all the necessary changes for PSM. Kai, could you review this patch? There are three *.chk files in NSS 3.8. 1. libsoftokn3.chk/softokn3.chk. 2. libfreebl_hybrid_3.chk. 3. libfreebl_pure32_3.chk. All platforms have the first one. Only 32-bit Solaris SPARC and HP-UX PA-RISC have the second and third ones. These *.chk files need to be installed in the same directory as the corresponding shared library/DLL.
Attachment #117506 -
Attachment is obsolete: true
Reporter | ||
Updated•21 years ago
|
Attachment #117569 -
Flags: review?(kaie)
Assignee | ||
Comment 3•21 years ago
|
||
Comment on attachment 117569 [details] [diff] [review] Proposed patch v2 looks ok to me. r=kaie
Attachment #117569 -
Flags: review?(kaie) → review+
Reporter | ||
Comment 4•21 years ago
|
||
The only difference from the previous version of the patch is that the .chk files are installed with 644 permissions (instead of 755) because the .chk files do not need execute permissions.
Attachment #117569 -
Attachment is obsolete: true
Reporter | ||
Updated•21 years ago
|
Attachment #117607 -
Flags: review?(kaie)
Assignee | ||
Comment 5•21 years ago
|
||
Comment on attachment 117607 [details] [diff] [review] Proposed patch v3 r=kaie
Attachment #117607 -
Flags: review?(kaie) → review+
Reporter | ||
Updated•21 years ago
|
Attachment #117607 -
Flags: superreview?(bryner)
Comment 6•21 years ago
|
||
Comment on attachment 117607 [details] [diff] [review] Proposed patch v3 If these .chk files are required in order for PSM to operate correctly, they should also be added to the packages-* files in xpinstall/packager; and to the embedding manifests in embedding/config (basebrowser-*).
Reporter | ||
Comment 7•21 years ago
|
||
Brian, Excellent point. I do have patches for the packages-* files in xpinstall/packager and the embedding manifests in embedding/config (basebrowser-*). They are attachment 117568 [details] [diff] [review] and attachment 117567 [details] [diff] [review] for bug 197874. I would appreciate it if you could super review these three patches. Please let me know if I missed anything else.
Updated•21 years ago
|
Attachment #117607 -
Flags: superreview?(bryner) → superreview+
Reporter | ||
Comment 8•21 years ago
|
||
Patch checked in. Kai, please set the target milestone.
Status: NEW → RESOLVED
Closed: 21 years ago
Resolution: --- → FIXED
Assignee | ||
Updated•21 years ago
|
Target Milestone: --- → 2.4
Updated•8 years ago
|
Product: Core → Core Graveyard
You need to log in
before you can comment on or make changes to this bug.
Description
•