1978788 - [wpt-sync] Sync PR 53917 - Patching: parse in fragment mode but inserting directly to target

Status: RESOLVED FIXED

(Core :: DOM: Core & HTML, task, P4)

Description

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Sync web-platform-tests PR 53917 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/53917
Details from upstream follow.

Noam Rosenthal <[e-mail]> wrote:

Patching: parse in fragment mode but inserting directly to target

Fragment parsing mode
(https://html.spec.whatwg.org/multipage/parsing.html#html-fragment-parsing-algorithm)
is a mode that sets up the parser correctly when parsing into a fragment
and we know the target of the fragment.

When patching, we use the same mechanism of setting up the parser, but
instead of parsing into a fragment we parse directly into the context
node.

Note that the fragment parsing algorithm spec doesn't actually require
a fragment as a parameter, it is used in the implementation as a way
to avoid creating an intermediate root element. This CL modifies the
places in the parser that expect a fragment root to expect the target
of fragment parsing instead, which may be any container node.

Bug: 431374376
Change-Id: If082086d5e999f159894f2506c9dc49d2ea1c7ce
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6772497
Commit-Queue: Noam Rosenthal \<[e-mail]>
Reviewed-by: Philip Jägenstedt \<[e-mail]>
Cr-Commit-Position: refs/heads/main@{#1490668}

Comment 1

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Pushed to try (stability) https://treeherder.mozilla.org/#/jobs?repo=try&revision=81f7bae6fb7090f2d220dd249b71948dff4882d5

Comment 2

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

CI Results

Ran 9 Firefox configurations based on mozilla-central, and Firefox, Chrome, and Safari on GitHub CI

Total 4 tests and 3 subtests

Status Summary

Firefox

OK : 4
FAIL : 6

Chrome

OK : 3
PASS : 4
FAIL : 1
ERROR: 1

Safari

OK : 4
FAIL : 6

Links

Gecko CI (Treeherder)
GitHub PR Head
GitHub PR Base

Details

New Tests That Don't Pass

• /html/dom/partial-updates/tentative/template-patchfor-script-eval.html [wpt.fyi]
  • HTML partial updates - patch updates script with plain text: FAIL (Chrome: PASS, Safari: FAIL)
• /html/dom/partial-updates/tentative/template-patchfor-script-plaintext.html [wpt.fyi]
  • <template patchfor> should apply directly to its target: FAIL (Safari: FAIL)
• /html/dom/partial-updates/tentative/template-patchfor-style-plaintext.html [wpt.fyi]
  • HTML partial updates - patch updates style with plain text: FAIL (Chrome: FAIL, Safari: FAIL)
• /html/dom/partial-updates/tentative/template-patchfor.html [wpt.fyi]
  • <template patchfor> should apply directly to its target: FAIL (Chrome: PASS, Safari: FAIL)
  • <template patchfor> should work when chunked: FAIL (Chrome: PASS, Safari: FAIL)
  • <template patchfor> should work when elements are sliced in the middle: FAIL (Chrome: PASS, Safari: FAIL)

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/984cf9f58311
https://hg.mozilla.org/integration/autoland/rev/b17103080ad4
[wpt PR 53917] - Patching: parse in fragment mode but inserting directly to target, a=testonly
https://github.com/mozilla-firefox/firefox/commit/8af5cd4f40ac
https://hg.mozilla.org/integration/autoland/rev/428390625428
[wpt PR 53917] - Update wpt metadata, a=testonly

Comment 4

[Cristian Tuns]

https://hg.mozilla.org/mozilla-central/rev/b17103080ad4
https://hg.mozilla.org/mozilla-central/rev/428390625428