1978849 - Improve reorg output

Status: RESOLVED FIXED

(Conduit :: moz-phab, defect)

Description

[Paul Adenot (:padenot)]

Print stack status (before, after), add hyperlinks, add a revision glossary.

Comment 1

[Paul Adenot (:padenot)]

Looks like this now:

$ moz-phab reorg nx rq   
Reorganisation based on 5 commits:
Stack will be reorganised:
 * D255521 will depend on D253058
 * D253058 will depend on D253367
 * D255521 will no longer depend on D254844
 * D258410 will depend on D255522
 * D254808 will be abandoned
 * D256926 will be abandoned

Referenced revisions:
 * D253058: Bug 1971158 - Vendor llama.cpp. r?glandium,sergesanspaille,atossou,tarek
 * D253367: Bug 1971158 - Copy and extend cmakeparser.py from libaom. r?sergesanspaille
 * D254808: Bug 1973711 - Add llama.cpp layer - r?tarek,padenot
 * D254844: WIP: Bug 1971158 - Allow compiling llama.cpp without dynamic_cast and exceptions with this one weird trick.
 * D255521: Bug 1971158 - Do not run our Sprintf Literal Checker clang plugin on third party code. r?andi
 * D255522: Bug 1971158 - Do not compile llama.cpp on Android. r?tarek,atossou
 * D256926: WIP: Bug 1976784 - Llama.cpp native peformance test r?tarek,padenot
 * D258410: Bug 1971158 - Don't crash in llama.cpp when an exception is caught for control flow and not error handling. r?atossou
Perform reorganisation (YES/No)?

and in verbose mode:

$ moz-phab reorg nx rq -v
Reorganisation based on 5 commits:

Stack reorganization details:
Current remote stack:
○ D256926 WIP: Bug 1976784 - Llama.cpp native peformance test r?tarek,padenot
○ D254808 Bug 1973711 - Add llama.cpp layer - r?tarek,padenot
○ D255522 Bug 1971158 - Do not compile llama.cpp on Android. r?tarek,atossou
○ D255521 Bug 1971158 - Do not run our Sprintf Literal Checker clang plugin on third party code. r?andi
○ D254844 WIP: Bug 1971158 - Allow compiling llama.cpp without dynamic_cast and exceptions with this one weird trick.
○ D253367 Bug 1971158 - Copy and extend cmakeparser.py from libaom. r?sergesanspaille
○ D253058 Bug 1971158 - Vendor llama.cpp. r?glandium,sergesanspaille,atossou,tarek
Target local stack:
○ D258410 Bug 1971158 - Don't crash in llama.cpp when an exception is caught for control flow and not error handling. r?atossou
○ D255522 Bug 1971158 - Do not compile llama.cpp on Android. r?tarek,atossou
○ D255521 Bug 1971158 - Do not run our Sprintf Literal Checker clang plugin on third party code. r?andi
○ D253058 Bug 1971158 - Vendor llama.cpp. r?glandium,sergesanspaille,atossou,tarek
○ D253367 Bug 1971158 - Copy and extend cmakeparser.py from libaom. r?sergesanspaille

Stack will be reorganised:
 * D255521 will depend on D253058
 * D253058 will depend on D253367
 * D255521 will no longer depend on D254844
 * D258410 will depend on D255522
 * D254808 will be abandoned
 * D256926 will be abandoned

all diff identifier and bug number are linkified by default. This can be disabled on the command line and also in the config file.

Comment 2

[Paul Adenot (:padenot)]

Attachment: Bug 1978849 - Don't use exception for control-flow. r?sheehan

Comment 3

[Paul Adenot (:padenot)]

Attachment: Bug 1978849 - Improve reorg output: print old and new stacks in verbose mode, add hyperlinks, add a revision glossary. r?sheehan

Comment 4

[BMO Github Automation]

Authored by https://github.com/padenot
https://github.com/mozilla-conduit/review/commit/8e7a15e99f7fa0b88a92742f35fca25ea1ab1462
[main] Bug 1978849 - Don't use exception for control-flow. r=sheehan

Authored by https://github.com/padenot
https://github.com/mozilla-conduit/review/commit/e07ce1673795bc94cef0ff5a2e7e612836d5efe7
[main] Bug 1978849 - Improve reorg output: print old and new stacks in verbose mode, add hyperlinks, add a revision glossary. r=sheehan