Closed Bug 1979066 Opened 8 months ago Closed 5 months ago

Intermittent browser/components/tabbrowser/test/browser/tabs/browser_tab_groups_telemetry.js | single tracking bug

Categories

(Firefox :: Tabbed Browser, defect, P5)

defect
Points:
1

Tracking

()

RESOLVED FIXED
146 Branch
Tracking Status
firefox146 --- fixed

People

(Reporter: intermittent-bug-filer, Assigned: sthompson)

References

(Blocks 1 open bug)

Details

(Keywords: intermittent-failure, intermittent-testcase, Whiteboard: [fidefe-tabgrps])

Attachments

(2 files, 1 obsolete file)

This passed when run in confirm failure mode (rerun the test 4x in the same session).

This indicates that the test is probably a lower frequency intermittent and harder to reproduce/debug.

Whiteboard: [collect_confirm_failure]
Assignee: nobody → chorotan
Status: NEW → ASSIGNED
Blocks: tab-groups
Whiteboard: [fidefe-tabgrps]

Fixes TypeError: can't access property "click", tabGroupButton is null that occurs when shouldSaveTabsToGroup(this.contextTabs) https://searchfox.org/firefox-main/rev/ad97131360471d36dfd9cf85695dde35914843bc/browser/components/tabbrowser/content/tabbrowser.js#9373 evaluates to false.

This patch ensures that all of the tabs are loaded and flushed to session state. This ensures the call to getContextMenu(win.gBrowser.tabs.at(-1), "tabContextMenu") will allow the TabContextMenu code to populate saved groups into the tab context menu.

Attachment #9514582 - Attachment is obsolete: true
Pushed by sthompson@mozilla.com: https://github.com/mozilla-firefox/firefox/commit/4d6e59083a05 https://hg.mozilla.org/integration/autoland/rev/15f5c89782b4 ensure context tab is loaded before opening context menu r=dwalker,tabbrowser-reviewers
Status: ASSIGNED → RESOLVED
Closed: 6 months ago
Resolution: --- → FIXED
Target Milestone: --- → 145 Branch
Assignee: chorotan → nobody
Status: RESOLVED → REOPENED
Flags: needinfo?(sthompson)
Resolution: FIXED → ---
Target Milestone: 145 Branch → ---

Looks like it was able to get further in the test but is now timing out elsewhere :(

I will work on a fix today.

Assignee: nobody → sthompson
Flags: needinfo?(sthompson)
Points: --- → 1
Attachment #9522418 - Attachment description: WIP: Bug 1979066 - reduce frequency of browser_tab_groups_telemetry intermittents → Bug 1979066 - try to reduce frequency of browser_tab_groups_telemetry intermittents r=dwalker,jswinarton
Pushed by sthompson@mozilla.com: https://github.com/mozilla-firefox/firefox/commit/657706db6552 https://hg.mozilla.org/integration/autoland/rev/9f1b7d9a6d3b try to reduce frequency of browser_tab_groups_telemetry intermittents r=jswinarton,tabbrowser-reviewers
Status: REOPENED → RESOLVED
Closed: 6 months ago5 months ago
Resolution: --- → FIXED
Target Milestone: --- → 146 Branch
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: