1979298 - [HDR] Delay publishing new layers untill we have all surfaces painted after LayerSet

Status: RESOLVED FIXED

(Core :: Graphics: WebRender, defect)

Description

[Martin Stránský [:stransky] (ni? me)]

We should delay painting to layers until we have all set to avoid flickering.

Comment 1

[Martin Stránský [:stransky] (ni? me)]

Looks like we also need to delay subsurface unmap until we have a new content as it's not synced:

Destroying a sub-surface takes effect immediately. If you need to synchronize the removal of a sub-surface to the parent surface update, unmap the sub-surface first by attaching a NULL wl_buffer, update parent, and then destroy the sub-surface.

Comment 2

[Martin Stránský [:stransky] (ni? me)]

Attachment: Bug 1979298 [HDR] Don't mark layers rendered if they're only visible r?emilio

Comment 3

[Martin Stránský [:stransky] (ni? me)]

Attachment: Bug 1979298 [HDR] Add rendered state to layers r?emilio

Comment 4

[Martin Stránský [:stransky] (ni? me)]

Attachment: Bug 1979298 [HDR] Rename root WaylandSurface to mRootSurface r?emilio

Comment 5

[Martin Stránský [:stransky] (ni? me)]

Attachment: Bug 1979298 [HDR] Delay commit to root WaylandSurface unless we have all changes in place to avoid flickering r?emilio

Comment 6

[Martin Stránský [:stransky] (ni? me)]

Attachment: Bug 1979298 [HDR] Add more debugging/logs to NativeLayerWayland r?emilio

Comment 7

[Martin Stránský [:stransky] (ni? me)]

Attachment: Bug 1979298 [HDR] Delay unmap of removed layers until we have new content available r?emilio

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/2ca68e9ddac8
https://hg.mozilla.org/integration/autoland/rev/b6af856c27e7
[HDR] Don't mark layers rendered if they're only visible r=emilio
https://github.com/mozilla-firefox/firefox/commit/66cde6292959
https://hg.mozilla.org/integration/autoland/rev/a643b5c35833
[HDR] Add rendered state to layers r=emilio
https://github.com/mozilla-firefox/firefox/commit/0e2ab1e6b1b4
https://hg.mozilla.org/integration/autoland/rev/3a39fb584630
[HDR] Rename root WaylandSurface to mRootSurface r=emilio
https://github.com/mozilla-firefox/firefox/commit/8ed5aa13bb37
https://hg.mozilla.org/integration/autoland/rev/7d404c8380f6
[HDR] Delay commit to root WaylandSurface unless we have all changes in place to avoid flickering r=emilio
https://github.com/mozilla-firefox/firefox/commit/6fd136092d2d
https://hg.mozilla.org/integration/autoland/rev/f9398fcc7913
[HDR] Add more debugging/logs to NativeLayerWayland r=emilio
https://github.com/mozilla-firefox/firefox/commit/d98e63d8b1f6
https://hg.mozilla.org/integration/autoland/rev/80fd50803ad0
[HDR] Delay unmap of removed layers until we have new content available r=emilio

Comment 9

[Cristina Horotan [:chorotan]]

https://hg.mozilla.org/mozilla-central/rev/b6af856c27e7
https://hg.mozilla.org/mozilla-central/rev/a643b5c35833
https://hg.mozilla.org/mozilla-central/rev/3a39fb584630
https://hg.mozilla.org/mozilla-central/rev/7d404c8380f6
https://hg.mozilla.org/mozilla-central/rev/f9398fcc7913
https://hg.mozilla.org/mozilla-central/rev/80fd50803ad0