Closed
Bug 1979318
Opened 5 months ago
Closed 4 months ago
Change reporting of sap.counts source field to match SERP events and other telemetry
Categories
(Firefox :: Search, task, P2)
Firefox
Search
Tracking
()
RESOLVED
FIXED
143 Branch
| Tracking | Status | |
|---|---|---|
| firefox143 | --- | fixed |
People
(Reporter: standard8, Assigned: standard8)
References
Details
(Whiteboard: [sng])
Attachments
(1 file)
When reporting the source for a search, most of our telemetry is using source names such as urlbar_persisted and urlbar_handoff, however the sap.counts event telemetry is using urlbar-persisted and urlbar-handoff. This causes us to need additional mappings of one to another.
Currently, the sap.deprecatedCounts also uses the underscore version. However, that is supporting legacy telemetry, and would be best not changed.
Given that sap.counts was only added in Firefox 138, and isn't being used for sources just yet, I would like to change the source reporting to be consistent with the rest of the telemetry. Once we drop sap.deprecatedCounts, we'll also be able to remove the mapping and simplify the code.
Updated•5 months ago
|
| Assignee | ||
Comment 1•5 months ago
|
||
Pushed by mbanner@mozilla.com:
https://github.com/mozilla-firefox/firefox/commit/a28a3b5a4f5d
https://hg.mozilla.org/integration/autoland/rev/661e8ff318ab
Change reporting of sap.counts source field to match SERP events and other telemetry. r=search-reviewers,scunnane
Comment 3•4 months ago
|
||
| bugherder | ||
Status: ASSIGNED → RESOLVED
Closed: 4 months ago
status-firefox143:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 143 Branch
Updated•4 months ago
|
QA Whiteboard: [search] [qa-triage-done-c143/b142]
You need to log in
before you can comment on or make changes to this bug.
Description
•