1979377 - Assertion failure: false (how does this happen?), at /builds/worker/checkouts/gecko/netwerk/protocol/http/Http2Session.cpp:417

Status: RESOLVED FIXED

(Core :: Networking: HTTP, defect, P2)

Description

[Tyson Smith [:tsmith] (PTO -> Sept/8)]

Found with m-c 20250725-eddfad0657e5 (--enable-debug)

This was found by visiting a live website with a debug build. A Pernosco session is available here: https://pernos.co/debug/tfNTQrRfC39xxnv0A5kKwg/index.html

STR:

• Launch browser and visit site

This issue was triggered by visiting http://strussia.ru/.

Assertion failure: false (how does this happen?), at /builds/worker/checkouts/gecko/netwerk/protocol/http/Http2Session.cpp:417

7|0|libxul.so|mozilla::net::Http2Session::RoomForMoreConcurrent()|hg:hg.mozilla.org/mozilla-central:netwerk/protocol/http/Http2Session.cpp:eddfad0657e522b395899a52ae0e4c69d32f6c68|417|0x8f
7|1|libxul.so|mozilla::net::Http2Session::ProcessPending()|hg:hg.mozilla.org/mozilla-central:netwerk/protocol/http/Http2Session.cpp:eddfad0657e522b395899a52ae0e4c69d32f6c68|691|0x35
7|2|libxul.so|mozilla::net::Http2Session::RecvSettings(mozilla::net::Http2Session*)|hg:hg.mozilla.org/mozilla-central:netwerk/protocol/http/Http2Session.cpp:eddfad0657e522b395899a52ae0e4c69d32f6c68|1824|0x2a9
7|3|libxul.so|mozilla::net::Http2Session::WriteSegmentsAgain(mozilla::net::nsAHttpSegmentWriter*, unsigned int, unsigned int*, bool*)|hg:hg.mozilla.org/mozilla-central:netwerk/protocol/http/Http2Session.cpp:eddfad0657e522b395899a52ae0e4c69d32f6c68|3262|0x963
7|4|libxul.so|mozilla::net::nsHttpConnection::OnSocketReadable()|hg:hg.mozilla.org/mozilla-central:netwerk/protocol/http/nsHttpConnection.cpp:eddfad0657e522b395899a52ae0e4c69d32f6c68|1888|0x151
7|5|libxul.so|mozilla::net::nsHttpConnection::OnInputStreamReady(nsIAsyncInputStream*)|hg:hg.mozilla.org/mozilla-central:netwerk/protocol/http/nsHttpConnection.cpp:eddfad0657e522b395899a52ae0e4c69d32f6c68|2236|0x97
7|6|libxul.so|mozilla::net::nsSocketInputStream::OnSocketReady(nsresult)|hg:hg.mozilla.org/mozilla-central:netwerk/base/nsSocketTransport2.cpp:eddfad0657e522b395899a52ae0e4c69d32f6c68|288|0xea
7|7|libxul.so|mozilla::net::nsSocketTransport::OnSocketReady(PRFileDesc*, short)|hg:hg.mozilla.org/mozilla-central:netwerk/base/nsSocketTransport2.cpp:eddfad0657e522b395899a52ae0e4c69d32f6c68|2162|0xc4
7|8|libxul.so|mozilla::net::nsSocketTransportService::DoPollIteration(mozilla::BaseTimeDuration<mozilla::TimeDurationValueCalculator>*)|hg:hg.mozilla.org/mozilla-central:netwerk/base/nsSocketTransportService2.cpp:eddfad0657e522b395899a52ae0e4c69d32f6c68||0x5b5
7|9|libxul.so|mozilla::net::nsSocketTransportService::Run()|hg:hg.mozilla.org/mozilla-central:netwerk/base/nsSocketTransportService2.cpp:eddfad0657e522b395899a52ae0e4c69d32f6c68|1177|0x310
7|10|libxul.so|{virtual override thunk({offset(-32)}, mozilla::net::nsSocketTransportService::Run())}|hg:hg.mozilla.org/mozilla-central:netwerk/base/nsSocketTransportService2.cpp:eddfad0657e522b395899a52ae0e4c69d32f6c68||0xc
7|11|libxul.so|nsThread::ProcessNextEvent(bool, bool*)|hg:hg.mozilla.org/mozilla-central:xpcom/threads/nsThread.cpp:eddfad0657e522b395899a52ae0e4c69d32f6c68|1153|0x77c
7|12|libxul.so|NS_ProcessNextEvent(nsIThread*, bool)|hg:hg.mozilla.org/mozilla-central:xpcom/threads/nsThreadUtils.cpp:eddfad0657e522b395899a52ae0e4c69d32f6c68|480|0x4f
7|13|libxul.so|mozilla::ipc::MessagePumpForNonMainThreads::Run(base::MessagePump::Delegate*)|hg:hg.mozilla.org/mozilla-central:ipc/glue/MessagePump.cpp:eddfad0657e522b395899a52ae0e4c69d32f6c68|299|0xc6
7|14|libxul.so|MessageLoop::Run()|hg:hg.mozilla.org/mozilla-central:ipc/chromium/src/base/message_loop.cc:eddfad0657e522b395899a52ae0e4c69d32f6c68|344|0x61
7|15|libxul.so|nsThread::ThreadFunc(void*)|hg:hg.mozilla.org/mozilla-central:xpcom/threads/nsThread.cpp:eddfad0657e522b395899a52ae0e4c69d32f6c68|366|0x1be
7|16|libnspr4.so|_pt_root|hg:hg.mozilla.org/mozilla-central:nsprpub/pr/src/pthreads/ptthread.c:eddfad0657e522b395899a52ae0e4c69d32f6c68|191|0x18f
7|17|firefox-bin|set_alt_signal_stack_and_start(PthreadCreateParams*)|hg:hg.mozilla.org/mozilla-central:mozglue/interposers/pthread_create_interposer.cpp:eddfad0657e522b395899a52ae0e4c69d32f6c68|81|0x10c

Comment 1

[Kershaw Chang [:kershaw]]

This is regressed by bug 1976964.
Apparently, when the server sends Firefox a new max concurrent stream setting, this could happen.
I think we can just remove that assertion.

Comment 2

[Kershaw Chang [:kershaw]]

Attachment: Bug 1979377 - Remove incorrect assertion, r=#necko

Comment 3

[BugBot [:suhaib / :marco]]

Set release status flags based on info from the regressing bug 1976964

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/c66c2fd80d6c
https://hg.mozilla.org/integration/autoland/rev/77b3a8a36778
Remove incorrect assertion, r=necko-reviewers,jesup

Comment 5

[Cristian Tuns]

https://hg.mozilla.org/mozilla-central/rev/77b3a8a36778