Closed
Bug 1979629
Opened 1 year ago
Closed 1 year ago
Fix a ruff warning in browser/locales/generate_ini.py
Categories
(Developer Infrastructure :: Lint and Formatting, enhancement)
Developer Infrastructure
Lint and Formatting
Tracking
(firefox143 fixed)
RESOLVED
FIXED
143 Branch
| Tracking | Status | |
|---|---|---|
| firefox143 | --- | fixed |
People
(Reporter: damia.vergnet, Assigned: damia.vergnet)
References
(Blocks 1 open bug)
Details
Attachments
(1 external file)
Steps to reproduce:
browser/locales/generate_ini.py
20:13 warning `for` loop variable `line` overwritten by assignment target PLW2901 (ruff)
21:13 warning `for` loop variable `line` overwritten by assignment target PLW2901 (ruff)
Link to the code:
https://searchfox.org/mozilla-central/source/browser/locales/generate_ini.py#20
|
Assignee | |
Comment 1•1 year ago
|
||
|
||
Updated•1 year ago
|
Assignee: nobody → damia.vergnet
Attachment #9503274 -
Attachment description: WIP: Bug 1979629 - browser/locales: fix ruff warning about overwritten for-loop variable → Bug 1979629 - browser/locales: fix ruff warning about overwritten for-loop variable. r=sylvestre
Status: UNCONFIRMED → ASSIGNED
Ever confirmed: true
|
|
Assignee | |
Comment 2•1 year ago
|
||
I assigned you (Sylvestre) as the reviewer as I saw that you were on other ruff-related bugs.
This is my first bug report so notify me if someone is better suited for this role and I’ll change it, and if there are things I should do to make better bug reports. Cheers.
Pushed by sledru@mozilla.com:
https://github.com/mozilla-firefox/firefox/commit/2f367f5ee270
https://hg.mozilla.org/integration/autoland/rev/17e0016c0244
browser/locales: fix ruff warning about overwritten for-loop variable. r=sylvestre
|
||
Comment 4•1 year ago
|
||
| bugherder | ||
Status: ASSIGNED → RESOLVED
Closed: 1 year ago
status-firefox143:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 143 Branch
You need to log in
before you can comment on or make changes to this bug.
Description
•