1979800 - Add strings for Firefox Labs experiment

Status: RESOLVED FIXED

(Firefox :: Shell Integration, task, P3)

Comment 1

[Nick Rishel [:nrishel]]

Attachment: Bug 1979800 - Add strings to support Firefox Web Apps in Firefox Labs. r=beth

Comment 2

[Nick Rishel [:nrishel]]

Attachment: Bug 1979800 - Add strings to support Firefox Web Apps in Firefox Labs. r=beth

Original Revision: https://phabricator.services.mozilla.com/D258993

Comment 3

[Phabricator Automation]

firefox-beta Uplift Approval Request

• User impact if declined: Delay in experimentation considered high priority by Product, risking future investment in a highly user requested feature.
• Code covered by automated testing: no
• Fix verified in Nightly: yes
• Needs manual QE test: no
• Steps to reproduce for manual QE testing: n/a
• Risk associated with taking this patch: Low
• Explanation of risk level: Only an l10n string, used by Labs. Pattern to create this is well known.
• String changes made/needed: Added strings for Firefox Web Apps Labs experiment. Does not require localization for Fx142.
• Is Android affected?: no

Edit: Beta patch is a combined patch to include Bug 1979800

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/716d205c8a45
https://hg.mozilla.org/integration/autoland/rev/2dd2f21b23d8
Add strings to support Firefox Web Apps in Firefox Labs. r=fluent-reviewers,bolsson

Comment 5

[Dianna Smith [:diannaS]]

Uplifting strings requires approval from l10n team

Comment 6

[[e-mail]]

https://hg.mozilla.org/mozilla-central/rev/2dd2f21b23d8

Comment 7

[Bryan Olsson [:bolsson]]

Does not require localization for Fx142.

Does this mean this particular Firefox Labs feature will only be exposed to English language locales? If that's the case no concerns.

Comment 8

[Nick Rishel [:nrishel]]

:bolsson Correct, this will only be used for English locales (for the Fx142 uplift).

Comment 9

[Bryan Olsson [:bolsson]]

Ok, thanks. No concerns then if English only for Fx142. Non-English locales would have enough time for localization for Fx143 onward.

Comment 10

[Pulsebot]

https://github.com/mozilla-firefox/firefox/commit/76baed98c3e2
https://hg.mozilla.org/releases/mozilla-beta/rev/a03545e1ac85