1979846 - Fix ruff warnings in dom/bindings/parser/tests/test_distinguishability.py

Status: RESOLVED FIXED

(Developer Infrastructure :: Lint and Formatting, enhancement)

Description

[Damia Vergnet]

Steps to reproduce:

Output of ./mach lint -W -l ruff . &> ruff.txt:

dom/bindings/parser/tests/test_distinguishability.py
  104:17  warning  Use format specifiers instead of percent format                                              UP031 (ruff)
  110:17  warning  Use format specifiers instead of percent format                                              UP031 (ruff)
  228:18  warning  Consider merging multiple comparisons: `a not in {"any", "Promise<any>", "Promise<any>?"}`.  PLR1714 (ruff)
  429:23  warning  Use format specifiers instead of percent format                                              UP031 (ruff)
  451:17  warning  Use format specifiers instead of percent format                                              UP031 (ruff)
  457:17  warning  Use format specifiers instead of percent format                                              UP031 (ruff)

Link to code:
https://searchfox.org/mozilla-central/source/dom/bindings/parser/tests/test_distinguishability.py

Comment 1

[Damia Vergnet]

Attachment: Bug 1979846 - ruff: fix warnings about %-format strings and values check in dom/bindings/parser/tests/test_distinguishability.py. r=sylvestre

Comment 2

[Damia Vergnet]

I’m planning on fixing all ruff warning within the dom/bindings/parser/ directory and its test/subdirectory as they’re very similar warnings. Should I make one bug report per file or one single bug report for all files?

Comment 3

[BugBot [:suhaib / :marco]]

There is an r+ patch which didn't land and no activity in this bug for 2 weeks.
:damia.vergnet, could you have a look please?
If you still have some work to do, you can add an action "Plan Changes" in Phabricator.
For more information, please visit BugBot documentation.

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/b868e85666cb
https://hg.mozilla.org/integration/autoland/rev/79fd32c74589
ruff: fix warnings about %-format strings and values check in dom/bindings/parser/tests/test_distinguishability.py. r=sylvestre

Comment 5

[Sylvestre Ledru [:Sylvestre]]

Damia, don't hesitate to ping us to land code!

Comment 6

[Cosmin Sabou [:CosminS]]

https://hg.mozilla.org/mozilla-central/rev/79fd32c74589