1979885 - Refactor last time review prompt shown trigger to use Nimbus

Status: RESOLVED FIXED

(Firefox for Android :: Experimentation and Telemetry, task)

Description

[Marcin Koziński]

Since we're evaluating all the other review prompt triggers with JEXL expressions, let's refactor the "hasn’t been shown in the last 4 months" criteria to also use this approach:

• Instead of updating settings.lastReviewPromptTimeInMillis when prompt is shown, record a new review_prompt_shown event in Nimbus, by calling Context.recordEventInNimbus("review_prompt_shown") (or directly nimbus.events.recordEvent("review_prompt_shown") if context isn't available).
• Then evaluate the criteria with this JEXL expression: 'review_prompt_shown'|eventLastSeen('Weeks') > 16.

(A month is tracked in Nimbus as a 28-day bucket, so converting it to 4 weeks doesn't change the semantics. Because of how buckets are advanced, using a monthly bucket can be almost an entire month off, so using weeks gives us better precision (means we might wait for 4 months and almost a week, instead of almost 5 months). This is why I opted for 16 weeks instead of 4 months.)

Comment 1

[Marcin Koziński]

Attachment: Bug 1979885 - Record an event in Nimbus instead of tracking last review prompt time manually

Comment 2

[Marcin Koziński]

Attachment: Bug 1979885 - Migrate existing last review prompt time values to a Nimbus event

Comment 3

[Marcin Koziński]

Attachment: Bug 1979885 - Make review prompt trigger function names more consistent

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/a30a6e03476c
https://hg.mozilla.org/integration/autoland/rev/4ba97f47caf8
Record an event in Nimbus instead of tracking last review prompt time manually r=android-reviewers,twhite
https://github.com/mozilla-firefox/firefox/commit/16c2a3def1a1
https://hg.mozilla.org/integration/autoland/rev/38667c22386d
Migrate existing last review prompt time values to a Nimbus event r=android-reviewers,twhite
https://github.com/mozilla-firefox/firefox/commit/c36d2dc527b6
https://hg.mozilla.org/integration/autoland/rev/5a51a0ffbf17
Make review prompt trigger function names more consistent r=android-reviewers,twhite

Comment 5

[Serban Stanca [:SerbanS]]

https://hg.mozilla.org/mozilla-central/rev/4ba97f47caf8
https://hg.mozilla.org/mozilla-central/rev/38667c22386d
https://hg.mozilla.org/mozilla-central/rev/5a51a0ffbf17

Comment 6

[John Oberhauser]

Attachment: Bug 1979885 - Record an event in Nimbus instead of tracking last review prompt time manually

Original Revision: https://phabricator.services.mozilla.com/D264050

Comment 7

[John Oberhauser]

Attachment: Bug 1979885 - Migrate existing last review prompt time values to a Nimbus event

Original Revision: https://phabricator.services.mozilla.com/D264051

Comment 8

[Phabricator Automation]

firefox-release Uplift Approval Request

• User impact if declined: This stack is required for uplifting D267229

D267229 is needed to help an incident where our play store ratings have fallen the past few days. It keeps legacy review prompt behavior if the nimbus flag for the custom review prompt is disabled

• Code covered by automated testing: yes
• Fix verified in Nightly: yes
• Needs manual QE test: no
• Steps to reproduce for manual QE testing: N/A
• Risk associated with taking this patch: low
• Explanation of risk level: These are minor changes to the review prompt feature.
• String changes made/needed: No
• Is Android affected?: yes

Comment 9

[John Oberhauser]

Attachment: Bug 1979885 - Make review prompt trigger function names more consistent

Original Revision: https://phabricator.services.mozilla.com/D264052

Comment 10

[Pulsebot]

https://github.com/mozilla-firefox/firefox/commit/498f9a6dd995
https://hg.mozilla.org/releases/mozilla-release/rev/6620078c1dab
https://github.com/mozilla-firefox/firefox/commit/7bddcb74bd0d
https://hg.mozilla.org/releases/mozilla-release/rev/d3b9bc5f8c6c
https://github.com/mozilla-firefox/firefox/commit/31536e6f4fcb
https://hg.mozilla.org/releases/mozilla-release/rev/ead6f4c03214