Closed Bug 1979927 Opened 22 days ago Closed 20 days ago

Do not run test cleanup steps if the session has ended in-between

Categories

(Remote Protocol :: Agent, task, P2)

Product:
Remote Protocol
Component:
Agent
Type:
task
Points:
2

Tracking

(firefox142 fixed, firefox143 fixed)

Status:
RESOLVED FIXED
Milestone:
143 Branch
Tracking Flags:
Tracking Status
firefox142 --- fixed
firefox143 --- fixed

People

(Reporter: Sasha, Assigned: Sasha)

References

Details

(Whiteboard: [webdriver:m17], [wptsync upstream])

Attachments

(2 files)

Bug 1979927 - Do not run test cleanup steps if the session has ended in-between.
48 bytes, text/x-phabricator-request
Details | Review
Bug 1979927 - Do not run test cleanup steps if the session has ended in-between.
48 bytes, text/x-phabricator-request
phab-bot
: approval-mozilla-beta+
Details | Review

The failures on bug 1965179, seems to be coming from the content crashes which happen later in the test or during cleanup. At the moment, we only check if the session has ended before running all the cleanup steps, but it looks like it can happen in between the steps, so we should rather check it before running each of them.

Assignee: nobody → aborovova
Status: NEW → ASSIGNED
Points: --- → 2
Priority: -- → P2
Whiteboard: [webdriver:m17]
Pushed by aborovova@mozilla.com: https://github.com/mozilla-firefox/firefox/commit/e6f90d431ccc https://hg.mozilla.org/integration/autoland/rev/ff387515ab30 Do not run test cleanup steps if the session has ended in-between. r=webdriver-reviewers,jdescottes
Created web-platform-tests PR https://github.com/web-platform-tests/wpt/pull/54063 for changes under testing/web-platform/tests
Whiteboard: [webdriver:m17] → [webdriver:m17], [wptsync upstream]

https://hg.mozilla.org/mozilla-central/rev/ff387515ab30

Status: ASSIGNED → RESOLVED
Closed: 20 days ago
status-firefox143: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 143 Branch
Upstream PR merged by moz-wptsync-bot
Upstream PR merged by moz-wptsync-bot
Attachment #9504838 - Flags: approval-mozilla-beta?

firefox-beta Uplift Approval Request

  • User impact if declined: None
  • Code covered by automated testing: yes
  • Fix verified in Nightly: yes
  • Needs manual QE test: no
  • Steps to reproduce for manual QE testing: None
  • Risk associated with taking this patch: Low
  • Explanation of risk level: Only affects wdspec tests
  • String changes made/needed: None
  • Is Android affected?: yes
Attachment #9504838 - Flags: approval-mozilla-beta? → approval-mozilla-beta+
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: