1979965 - Update PreserveWrapperCallback signature to reflect the present reality that it's infallible

Status: RESOLVED FIXED

(Core :: JavaScript Engine, task, P3)

Description

[Alex Thayer [:alexical] (she/her)]

Currently the callback signature has a bool return value suggesting it can fail, but in practice it cannot, so we should just clean that up.

Comment 1

[Tom Schuster]

This change would have marginally simplified my code review experience for bug 2038575.

Comment 2

[Jan de Mooij [:jandem]]

Stealing because this also comes up in code audits sometimes.

Comment 3

[Jan de Mooij [:jandem]]

Attachment: Bug 1979965 part 1 - Make dom::TryPreserveWrapper infallible. r?#spidermonkey-reviewers!

Comment 4

[Jan de Mooij [:jandem]]

Attachment: Bug 1979965 part 2 - Make PreserveWrapperCallback infallible. r?#spidermonkey-reviewers!

We already asserted this; the patch just makes it explicit.

Comment 5

[Jan de Mooij [:jandem]]

Attachment: Bug 1979965 part 3 - Inline WeakRefObject::preserveDOMWrapper and FinalizationRegistryObject::preserveDOMWrapper. r?#spidermonkey-reviewers!

Comment 6

[Jan de Mooij [:jandem]]

Attachment: Bug 1979965 part 4 - Assert pending wrapper preservations are never CCWs. r?#spidermonkey-reviewers!

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/343c90b97936
https://hg.mozilla.org/integration/autoland/rev/825bf4f2cc1e
part 1 - Make dom::TryPreserveWrapper infallible. r=spidermonkey-reviewers,dom-worker-reviewers,mccr8,mgaudet,asuth
https://github.com/mozilla-firefox/firefox/commit/3becbccee3d6
https://hg.mozilla.org/integration/autoland/rev/7c952600ea00
part 2 - Make PreserveWrapperCallback infallible. r=spidermonkey-reviewers,dom-worker-reviewers,mccr8,mgaudet,asuth
https://github.com/mozilla-firefox/firefox/commit/58c8e6098067
https://hg.mozilla.org/integration/autoland/rev/72881acbe1a5
part 3 - Inline WeakRefObject::preserveDOMWrapper and FinalizationRegistryObject::preserveDOMWrapper. r=spidermonkey-reviewers,mgaudet
https://github.com/mozilla-firefox/firefox/commit/8a335fb54823
https://hg.mozilla.org/integration/autoland/rev/6cf788dbc3c3
part 4 - Assert pending wrapper preservations are never CCWs. r=spidermonkey-reviewers,mgaudet

Comment 8

[Cosmin Sabou [:CosminS]]

https://hg.mozilla.org/mozilla-central/rev/825bf4f2cc1e
https://hg.mozilla.org/mozilla-central/rev/7c952600ea00
https://hg.mozilla.org/mozilla-central/rev/72881acbe1a5
https://hg.mozilla.org/mozilla-central/rev/6cf788dbc3c3