1979992 - Add `--skip-android` to `mach format` in Lando Autoformatting

Status: RESOLVED FIXED

(Conduit :: Lando, task)

Description

[Alex Hochheiden [:ahochheiden] [he/him]]

Bug 1977641 makes changes to MachCommandConditions which impacts ./mach format (Which Lando uses for autoformatting). It essentially makes ./mach configure running a requirement when checking for a conditions that requires it. For ./mach configure to succeed, we need to do a full bootstrap, and we'd need that to succeed. As seen in bug 1972167 making Lando strictly require ./mach bootstrap to succeed is not a good idea.

Given that the conditions.is_android(command_context) was previously always returning False anyway (without being able to properly evaluate the condition), we were effectively always skipping Android formatters anyway. As such, bug 1977641 added an arg to enable explicitly skipping this check in D259154. We just need to pass the new arg here when we call ./mach format in Lando.

Comment 1

[BMO Github Automation]

Attachment: [mozilla-conduit/lando] landing_worker: Add "--skip-android" to "./mach format" call (Bug 1979992) (#443)

Comment 2

[BMO Github Automation]

Authored by https://github.com/ahochheiden
https://github.com/mozilla-conduit/lando/commit/b823e62b9ef87b188b21b9db62537420482131ef
[main] landing_worker: Add "--skip-android" to "./mach format" call (Bug 1979992) (#443)