Open Bug 1980036 Opened 8 months ago Updated 14 hours ago

Frequent browser/components/tabbrowser/test/browser/tabs/browser_tab_preview.js | single tracking bug

Categories

(Firefox :: Tabbed Browser, defect, P1)

defect

Tracking

()

Tracking Status
firefox-esr140 --- unaffected
firefox145 --- unaffected
firefox146 --- unaffected
firefox147 --- affected
firefox148 --- affected

People

(Reporter: intermittent-bug-filer, Assigned: jswinarton)

References

(Depends on 1 open bug, Regression)

Details

(4 keywords, Whiteboard: [stockwell disabled][fidefe-tabgrps])

Attachments

(7 files, 2 obsolete files)

48 bytes, text/x-phabricator-request
Details | Review
48 bytes, text/x-phabricator-request
Details | Review
48 bytes, text/x-phabricator-request
Details | Review
48 bytes, text/x-phabricator-request
Details | Review
48 bytes, text/x-phabricator-request
Details | Review
48 bytes, text/x-phabricator-request
Details | Review
48 bytes, text/x-phabricator-request
Details | Review

Filed by: agoloman [at] mozilla.com
Parsed log: https://treeherder.mozilla.org/logviewer?job_id=520064141&repo=autoland
Full log: https://firefox-ci-tc.services.mozilla.com/api/queue/v1/task/F3xgs6UPQmG2IbezEJApvQ/runs/0/artifacts/public/logs/live_backing.log


[task 2025-07-30T00:18:04.458+00:00] 00:18:04     INFO - TEST-PASS | browser/components/tabbrowser/test/browser/tabs/browser_tab_preview.js | sanity check: no panels open - true == true - 
[task 2025-07-30T00:18:04.458+00:00] 00:18:04     INFO - Leaving test bound urlBarInputTests
[task 2025-07-30T00:18:04.458+00:00] 00:18:04     INFO - Entering test bound zeroDelayTests
[task 2025-07-30T00:18:04.459+00:00] 00:18:04     INFO - Console message: [JavaScript Warning: "This page is in Quirks Mode. Page layout may be impacted. For Standards Mode use “<!DOCTYPE html>”." {file: "data:text/html,<html><head><title>First New Tab</title></head><body>Hello</body></html>" line: 0}]
[task 2025-07-30T00:18:04.459+00:00] 00:18:04     INFO - Buffered messages finished
[task 2025-07-30T00:18:04.460+00:00] 00:18:04     INFO - TEST-UNEXPECTED-FAIL | browser/components/tabbrowser/test/browser/tabs/browser_tab_preview.js | Zero delay is set immediately after leaving tab strip - false == true - 
[task 2025-07-30T00:18:04.460+00:00] 00:18:04     INFO - Stack trace:
[task 2025-07-30T00:18:04.460+00:00] 00:18:04     INFO - chrome://mochitests/content/browser/browser/components/tabbrowser/test/browser/tabs/browser_tab_preview.js:zeroDelayTests:822
[task 2025-07-30T00:18:04.460+00:00] 00:18:04     INFO - chrome://mochikit/content/browser-test.js:handleTask:1238
[task 2025-07-30T00:18:04.460+00:00] 00:18:04     INFO - chrome://mochikit/content/browser-test.js:_runTaskBasedTest:1314
[task 2025-07-30T00:18:04.460+00:00] 00:18:04     INFO - chrome://mochikit/content/browser-test.js:Tester_execTest:1461
[task 2025-07-30T00:18:04.460+00:00] 00:18:04     INFO - chrome://mochikit/content/browser-test.js:nextTest/<:1220
[task 2025-07-30T00:18:04.460+00:00] 00:18:04     INFO - chrome://mochikit/content/tests/SimpleTest/SimpleTest.js:SimpleTest.waitForFocus/<:1058
[task 2025-07-30T00:18:04.461+00:00] 00:18:04     INFO - Not taking screenshot here: see the one that was previously logged
[task 2025-07-30T00:18:04.461+00:00] 00:18:04     INFO - TEST-UNEXPECTED-FAIL | browser/components/tabbrowser/test/browser/tabs/browser_tab_preview.js | sanity check: no panels open - false == true - 
[task 2025-07-30T00:18:04.462+00:00] 00:18:04     INFO - Stack trace:
[task 2025-07-30T00:18:04.462+00:00] 00:18:04     INFO - chrome://mochitests/content/browser/browser/components/tabbrowser/test/browser/tabs/browser_tab_preview.js:resetState:59
[task 2025-07-30T00:18:04.462+00:00] 00:18:04     INFO - chrome://mochitests/content/browser/browser/components/tabbrowser/test/browser/tabs/browser_tab_preview.js:zeroDelayTests:827
[task 2025-07-30T00:18:04.462+00:00] 00:18:04     INFO - chrome://mochikit/content/browser-test.js:handleTask:1238
[task 2025-07-30T00:18:04.462+00:00] 00:18:04     INFO - chrome://mochikit/content/browser-test.js:_runTaskBasedTest:1314
[task 2025-07-30T00:18:04.462+00:00] 00:18:04     INFO - chrome://mochikit/content/browser-test.js:Tester_execTest:1461
[task 2025-07-30T00:18:04.462+00:00] 00:18:04     INFO - chrome://mochikit/content/browser-test.js:nextTest/<:1220
[task 2025-07-30T00:18:04.462+00:00] 00:18:04     INFO - chrome://mochikit/content/tests/SimpleTest/SimpleTest.js:SimpleTest.waitForFocus/<:1058
[task 2025-07-30T00:18:04.462+00:00] 00:18:04     INFO - Leaving test bound zeroDelayTests
[task 2025-07-30T00:18:04.462+00:00] 00:18:04     INFO - Entering test bound wheelTests
[task 2025-07-30T00:18:04.761+00:00] 00:18:04     INFO - TEST-PASS | browser/components/tabbrowser/test/browser/tabs/browser_tab_preview.js | Panel does not have rolluponmousewheel when no overflow - true == true - 

This passed when run in confirm failure mode (rerun the test 4x in the same session).

This indicates that the test is probably a lower frequency intermittent and harder to reproduce/debug.

Whiteboard: [collect_confirm_failure]

Started retriggers here

But this started to fail after https://bugzilla.mozilla.org/show_bug.cgi?id=1905944#c64 landed.

Done some backfills here, it seems that from your latest push it started to fail more frequent, Jeremy could you please have another look? There are 127 failures in the last 7 days, affecting multiple platforms not only MacOS, but indeed only failing with "Zero delay is set immediately after leaving tab strip - false == true)". Should we disable the test as mentioned in https://bugzilla.mozilla.org/show_bug.cgi?id=1971237#c13?

Flags: needinfo?(jswinarton)
Summary: Intermittent browser/components/tabbrowser/test/browser/tabs/browser_tab_preview.js | single tracking bug → Frequent browser/components/tabbrowser/test/browser/tabs/browser_tab_preview.js | single tracking bug
Assignee: nobody → jswinarton
Flags: needinfo?(jswinarton)

Hi :chorotan, I will investigate this. I'm working on a few fixes for tab hover preview related functionality and I suspect this one may be caused by bug1983054. I will let you know when I get closer to a fix.

Until a fix is in place, I made a patch to disable the test because we have over 500+ failures in the last 30 days

Pushed by smolnar@mozilla.com: https://github.com/mozilla-firefox/firefox/commit/674ce70a6f17 https://hg.mozilla.org/integration/autoland/rev/6535e8af3d8d Disable browser_tab_preview.js for frequent failures. r=intermittent-reviewers,jmaher DONTBUILD
Keywords: leave-open
Whiteboard: [stockwell disabled]
Attachment #9513450 - Attachment description: WIP: Bug 1980036: Fix intermittents in browser_tab_preview.js → Bug 1980036: Fix intermittents in browser_tab_preview.js r?dwalker,sthompson

Just leaving a note here to confirm that I am actively investigating this.

Thank you for investigating, there already are 130 failures in the last 7 days.

Whiteboard: [stockwell disabled] → [stockwell disabled][fidefe-tabgrps]
Pushed by jswinarton@mozilla.com: https://github.com/mozilla-firefox/firefox/commit/95b1e4bba4aa https://hg.mozilla.org/integration/autoland/rev/37f4982ce359 Prevent duplicate calls to THP deactivate() and make the panel respect changes to ui.tooltip.delay_ms r=dwalker,tabbrowser-reviewers
Pushed by imoraru@mozilla.com: https://github.com/mozilla-firefox/firefox/commit/247d308c4cf4 https://hg.mozilla.org/integration/autoland/rev/f5b2445473ae Revert "Bug 1980036: Prevent duplicate calls to THP deactivate() and make the panel respect changes to ui.tooltip.delay_ms r=dwalker,tabbrowser-reviewers" for causing bc failures on browser_tabReorder_vertical.js.

Revert for causing bc failures on browser_tabReorder_vertical.js.

[task 2025-09-24T15:41:37.496+00:00] 15:41:37     INFO - GECKO(1498) | [Parent 1498: Main Thread]: I/DocShellAndDOMWindowLeak --DOMWINDOW == 0 (7f620d426900) [pid = 1498] [serial = 2] [outer = 0] [url = about:blank]
[task 2025-09-24T15:41:37.518+00:00] 15:41:37     INFO - GECKO(1498) | [Parent 1498, Main Thread] WARNING: NS_ENSURE_SUCCESS_VOID(rv) failed with result 0x8000FFFF (NS_ERROR_UNEXPECTED): file /builds/worker/checkouts/gecko/dom/file/uri/BlobURLProtocolHandler.cpp:419
[task 2025-09-24T15:41:37.519+00:00] 15:41:37     INFO - GECKO(1498) | [Parent 1498, Main Thread] WARNING: NS_ENSURE_TRUE(!!svc) failed: file /builds/worker/checkouts/gecko/dom/file/uri/BlobURLProtocolHandler.cpp:528
[task 2025-09-24T15:41:37.663+00:00] 15:41:37     INFO - TEST-INFO | Main app process: exit 0
[task 2025-09-24T15:41:37.663+00:00] 15:41:37     INFO - TEST-INFO | Confirming we saw 1910 DOCSHELL created and 1909 destroyed log strings.
[task 2025-09-24T15:41:37.663+00:00] 15:41:37     INFO - TEST-INFO | Confirming we saw 5142 DOMWINDOW created and 5139 destroyed log strings.
[task 2025-09-24T15:41:37.664+00:00] 15:41:37     INFO - TEST-INFO | browser/components/tabbrowser/test/browser/tabs/browser_tabReorder_vertical.js | windows(s) leaked: [pid = 1498] [serial = 418], [pid = 1498] [serial = 419]
[task 2025-09-24T15:41:37.665+00:00] 15:41:37     INFO - TEST-UNEXPECTED-FAIL | browser/components/tabbrowser/test/browser/tabs/browser_tabReorder_vertical.js | leaked 1 window(s) until shutdown [url = chrome://browser/content/browser.xhtml]
[task 2025-09-24T15:41:37.665+00:00] 15:41:37     INFO - TEST-INFO 
[task 2025-09-24T15:41:37.665+00:00] 15:41:37     INFO - TEST-UNEXPECTED-FAIL | browser/components/tabbrowser/test/browser/tabs/browser_tabReorder_vertical.js | leaked 1 window(s) until shutdown [url = about:blank]
[task 2025-09-24T15:41:37.665+00:00] 15:41:37     INFO - TEST-INFO 
[task 2025-09-24T15:41:37.666+00:00] 15:41:37     INFO - runtests.py | Application ran for: 0:08:40.168340
[task 2025-09-24T15:41:37.666+00:00] 15:41:37     INFO - zombiecheck | Reading PID log: /tmp/tmp5ggtwoowpidlog
[task 2025-09-24T15:41:37.666+00:00] 15:41:37     INFO - ==> process 1498 launched child process 1608
[task 2025-09-24T15:41:37.667+00:00] 15:41:37     INFO - ==> process 1498 launched child process 17965
[task 2025-09-24T15:41:37.667+00:00] 15:41:37     INFO - zombiecheck | Checking for orphan process with PID: 1608
[task 2025-09-24T15:41:37.667+00:00] 15:41:37     INFO - zombiecheck | Checking for orphan process with PID: 17965
[task 2025-09-24T15:41:37.667+00:00] 15:41:37     INFO - runtests.py | Running http tests: end. status: 0
[task 2025-09-24T15:41:37.669+00:00] 15:41:37     INFO - Stopping web server
[task 2025-09-24T15:41:37.689+00:00] 15:41:37     INFO - Server shut down.
Flags: needinfo?(jswinarton)
Attachment #9515316 - Attachment description: Bug 1980036: Prevent duplicate calls to THP deactivate() and make the panel respect changes to ui.tooltip.delay_ms r?dwalker,sthompson → Bug 1980036: Make the THP/TGHP panel respect changes to ui.tooltip.delay_ms r?dwalker,sthompson
Pushed by jswinarton@mozilla.com: https://github.com/mozilla-firefox/firefox/commit/e7b2da7d5a80 https://hg.mozilla.org/integration/autoland/rev/b9a61e190044 Make the THP/TGHP panel respect changes to ui.tooltip.delay_ms r=dwalker,tabbrowser-reviewers
Pushed by jswinarton@mozilla.com: https://github.com/mozilla-firefox/firefox/commit/6b3a47799e83 https://hg.mozilla.org/integration/autoland/rev/a9b8972bccea Ignore calls to deactivate THP/TGHP if already hidden r=sthompson,tabbrowser-reviewers
Pushed by abutkovits@mozilla.com: https://github.com/mozilla-firefox/firefox/commit/5479132f1960 https://hg.mozilla.org/integration/autoland/rev/3f077a0ad87c Revert "Bug 1980036: Ignore calls to deactivate THP/TGHP if already hidden r=sthompson,tabbrowser-reviewers" for causing failures at browser_bookmarksProperties.js.
Pushed by chorotan@mozilla.com: https://github.com/mozilla-firefox/firefox/commit/d93f5118c7b4 https://hg.mozilla.org/integration/autoland/rev/a95c167247a2 disable browser_tab_preview.js on mac and linux for frequent failures r=tabbrowser-reviewers,sthompson
Attachment #9516591 - Attachment is obsolete: true
Attachment #9522726 - Attachment description: WIP: Bug 1980036: Stop THP/TGHP from suppressing panel open requests from the other panel element → Bug 1980036: Stop THP/TGHP from suppressing panel open requests from the other panel element r?dwalker,sthompson
Attachment #9522659 - Attachment is obsolete: true
Pushed by jswinarton@mozilla.com: https://github.com/mozilla-firefox/firefox/commit/e0722384b722 https://hg.mozilla.org/integration/autoland/rev/e9b43a8df355 Stop THP/TGHP from suppressing panel open requests from the other panel element r=sthompson,tabbrowser-reviewers
Attachment #9524717 - Attachment description: WIP: Bug 1980036: Suppress TGHP/THP panel activation logic if already open, and improve zero delay reset logic → Bug 1980036: Suppress TGHP/THP panel activation logic if already open, and improve zero delay reset logic r?dwalker,sthompson

I have another patch that should fix the last of the intermittents on this test file. I'm just waiting to land until 2025-11-11 since the code freeze is currently in effect.

Flags: needinfo?(jswinarton)
Pushed by jswinarton@mozilla.com: https://github.com/mozilla-firefox/firefox/commit/3a04ff1cc8bb https://hg.mozilla.org/integration/autoland/rev/2b924dd17fc7 Suppress TGHP/THP panel activation logic if already open, and improve zero delay reset logic r=sthompson,tabbrowser-reviewers
Blocks: 1997790
Regressions: 2001594
Keywords: regression
Regressed by: 1995296

Set release status flags based on info from the regressing bug 1995296

Set release status flags based on info from the regressing bug 1995296

Priority: P5 → P1
Depends on: 2032637
Pushed by archaeopteryx@coole-files.de: https://github.com/mozilla-firefox/firefox/commit/b9564567131d https://hg.mozilla.org/integration/autoland/rev/bb732fbb5f97 Disable browser_tab_preview.js for frequent failures. r=intermittent-reviewers,ahal DONTBUILD
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: