1980103 - Vendoring could fill git's export-subst

Status: NEW

(Developer Infrastructure :: Mach Vendor & Updatebot, defect)

Description

[Pier Angelo Vendrame]

Bug 1897851 introduced testing/web-platform/tests/tools/third_party/attrs/.git_archival.txt, which is filled when running git archive because of the export-subst setting in testing/web-platform/tests/tools/third_party/attrs/.gitattributes.
However, as a consequence, that that file will contain the information about Firefox's tree when running git archive on a Firefox clone.
I think it'd make sense to fill the file during the vendoring with the information of the upstream repository, instead.
FWIW, that file can become a problem for deterministically creating a tarball of Firefox's source (that's how we noticed this downstream at Tor Browser).

Comment 1

[BugBot [:suhaib / :marco]]

Set release status flags based on info from the regressing bug 1897851

Comment 2

[Tom Ritter [:tjr]]

I see that jgraham did the bump a year ago and that the issue was fixed (or possibly here?).

So it semms like mayeb wpt bumping attrs again, and then us pulling in their bump would work?

Comment 3

[James Graham [:jgraham]]

I've tried updating this upstream in https://github.com/web-platform-tests/wpt/pull/54161; let's see if that causes any problems.

Comment 4

[BugBot [:suhaib / :marco]]

The severity field is not set for this bug.
:tjr, could you have a look please?

For more information, please visit BugBot documentation.