1980141 - [wpt-sync] Sync PR 54048 - Update letter-spacing to use ComputedLetterSpacing() for animation

Status: RESOLVED FIXED

(Core :: DOM: Animation, task, P4)

Description

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Sync web-platform-tests PR 54048 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/54048
Details from upstream follow.

Minseong Kim <[e-mail]> wrote:

Update letter-spacing to use ComputedLetterSpacing() for animation

LengthPropertyFunctions::GetInitialLength was using
style.LetterSpacing() to get the value for the letter-spacing
property. This is incorrect as it only returns a fixed float value and
does not correctly handle percentage or calc() values.

This CL switches to using style.ComputedLetterSpacing() which returns
the correct computed Length object.

The corresponding Web Platform Test is also updated to reflect that the
animation type for letter-spacing is lengthPercentageOrCalc.

Bug: 327740939
Change-Id: I1e093692ec3802a378486483f85af7a8113eaca9
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6796854
Reviewed-by: Rune Lillesveen \<[e-mail]>
Reviewed-by: Koji Ishii \<[e-mail]>
Commit-Queue: 김민성 \<[e-mail]>
Cr-Commit-Position: refs/heads/main@{#1494078}

Comment 1

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Pushed to try (stability) https://treeherder.mozilla.org/#/jobs?repo=try&revision=c0a76af2e6cdadcec7b543845f277b5fb9d2e6d5

Comment 2

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

CI Results

Ran 0 Firefox configurations based on mozilla-central, and Firefox, Chrome, and Safari on GitHub CI

Total 6 tests and 496 subtests

Status Summary

Firefox

OK : 6
PASS: 2328
FAIL: 12

Chrome

OK : 6
PASS: 2404
FAIL: 75

Safari

OK : 6
PASS: 2406
FAIL: 20

Links

GitHub PR Head
GitHub PR Base

Details

Firefox-only Failures

• /web-animations/animation-model/animation-types/accumulation-per-property-002.html [wpt.fyi]
  • list-style: "outside url("http://localhost/test-2") square" onto "inside url("http://localhost/test-1") circle": FAIL
• /web-animations/animation-model/animation-types/addition-per-property-002.html [wpt.fyi]
  • list-style: "outside url("http://localhost/test-2") square" onto "inside url("http://localhost/test-1") circle": FAIL

New Tests That Don't Pass

• /web-animations/animation-model/animation-types/accumulation-per-property-002.html [wpt.fyi]
  • list-style: "outside url("http://localhost/test-2") square" onto "inside url("http://localhost/test-1") circle": FAIL (Chrome: PASS, Safari: PASS)
  • text-decoration: "overline" onto "underline": FAIL (Chrome: FAIL, Safari: PASS)
  • text-decoration: "underline" onto "overline": FAIL (Chrome: FAIL, Safari: PASS)
• /web-animations/animation-model/animation-types/addition-per-property-002.html [wpt.fyi]
  • list-style: "outside url("http://localhost/test-2") square" onto "inside url("http://localhost/test-1") circle": FAIL (Chrome: PASS, Safari: PASS)
  • text-decoration: "overline" onto "underline": FAIL (Chrome: FAIL, Safari: PASS)
  • text-decoration: "underline" onto "overline": FAIL (Chrome: FAIL, Safari: PASS)
• /web-animations/animation-model/animation-types/interpolation-per-property-002.html [wpt.fyi]
  • list-style uses discrete animation when animating between "inside url("http://localhost/test-1") circle" and "outside url("http://localhost/test-2") square" with linear easing: FAIL (Chrome: FAIL, Safari: FAIL)
  • list-style uses discrete animation when animating between "inside url("http://localhost/test-1") circle" and "outside url("http://localhost/test-2") square" with effect easing: FAIL (Chrome: FAIL, Safari: FAIL)
  • list-style uses discrete animation when animating between "inside url("http://localhost/test-1") circle" and "outside url("http://localhost/test-2") square" with keyframe easing: FAIL (Chrome: FAIL, Safari: FAIL)
  • text-decoration uses discrete animation when animating between "underline" and "overline" with linear easing: FAIL (Chrome: FAIL, Safari: PASS)
  • text-decoration uses discrete animation when animating between "underline" and "overline" with effect easing: FAIL (Chrome: FAIL, Safari: PASS)
  • text-decoration uses discrete animation when animating between "underline" and "overline" with keyframe easing: FAIL (Chrome: FAIL, Safari: PASS)

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/77256555dd97
https://hg.mozilla.org/integration/autoland/rev/d506dfa90cbf
[wpt PR 54048] - Update letter-spacing to use ComputedLetterSpacing() for animation, a=testonly

Comment 4

[Narcis Beleuzu [:NarcisB]]

https://hg.mozilla.org/mozilla-central/rev/d506dfa90cbf