1980177 - Crash in [@ mozilla::Maybe<T>::extract | mozilla::dom::indexedDB::(anonymous namespace)::Maintenance::DirectoryWork::<T>::operator()]

Status: RESOLVED FIXED

(Core :: Storage: Quota Manager, defect, P2)

Description

[Andrew McCreight [:mccr8]]

Crash report: https://crash-stats.mozilla.org/report/index/bf1fa816-38ef-4f1f-957d-907220250724

MOZ_CRASH Reason:

MOZ_RELEASE_ASSERT(isSome())

Top 10 frames:

0  xul.dll  mozilla::Maybe<mozilla::dom::quota::OriginStateMetadata>::extract()  mfbt/Maybe.h:488
0  xul.dll  mozilla::dom::indexedDB::(anonymous namespace)::Maintenance::DirectoryWork::<...  dom/indexedDB/ActorsParent.cpp:13392
0  xul.dll  mozilla::CollectEach(mozilla::dom::quota::detail::CollectEachFile<`lambda at ...  dom/quota/QuotaCommon.h:1191
0  xul.dll  mozilla::dom::quota::detail::CollectEachFile(nsIFile&, mozilla::dom::quota::C...  dom/quota/QuotaCommon.h:1599
0  xul.dll  mozilla::dom::quota::CollectEachFile<`lambda at /builds/worker/checkouts/geck...  dom/quota/QuotaCommon.h:1615
1  xul.dll  mozilla::dom::indexedDB::(anonymous namespace)::Maintenance::DirectoryWork()  dom/indexedDB/ActorsParent.cpp:13392
1  xul.dll  mozilla::dom::indexedDB::(anonymous namespace)::Maintenance::Run()  dom/indexedDB/ActorsParent.cpp:13730
2  xul.dll  nsThread::ProcessNextEvent(bool, bool*)  xpcom/threads/nsThread.cpp:1153
2  xul.dll  NS_ProcessNextEvent(nsIThread*, bool)  xpcom/threads/nsThreadUtils.cpp:480
3  xul.dll  mozilla::ipc::MessagePumpForNonMainThreads::Run(base::MessagePump::Delegate*)  ipc/glue/MessagePump.cpp:329

Bug 1972843 was supposed to fix this signature, but we're still seeing some kind of crashes, so here's a new bug to track that.

Comment 1

[Andrew McCreight [:mccr8]]

From the other bug:

(In reply to Harveer Singh from comment #6)

Assertion is coming from here.
I believe this is happening because we are attempting to perform maintenance before QuotaManager is initialized and as a result 'maybeOriginStateMetadata' came out as empty above.

Comment 2

[Harveer Singh]

Attachment: Bug 1980177: Skip over origins and log a telemetry for origins with unknown metadata when performing idb maintenance.r=asuth

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/7cb4d781efa6
https://hg.mozilla.org/integration/autoland/rev/f49e6797d395
Skip over origins and log a telemetry for origins with unknown metadata when performing idb maintenance.r=asuth,dom-storage-reviewers,toolkit-telemetry-reviewers,TravisLong

Comment 4

[pstanciu]

https://hg.mozilla.org/mozilla-central/rev/f49e6797d395