1980211 - Locale override is sometimes shared between BrowsingContexts

Status: RESOLVED FIXED

(Remote Protocol :: WebDriver BiDi, defect, P2)

Description

[Holger Benl [:hbenl]]

While working on this PR I noticed the test "should be isolated between contexts" in tests/library/browsercontext-locale.spec.ts fails. The test creates 8 playwright pages with one locale and then another one with a different locale (note this comment). If I reduce the number of pages then the test succeeds.

Comment 1

[Alexandra Borovova [:Sasha]]

Attachment: Bug 1980211 - Attach locale override to Realm instead of setting it in the process.

Comment 2

[Alexandra Borovova [:Sasha]]

Attachment: Bug 1980211 - [wdspec] Fix "another_locale" fixture.

Comment 3

[Alexandra Borovova [:Sasha]]

Attachment: Bug 1980211 - Add gecko specific test to verify that locale override is isolated inside browsing context.

Comment 4

[Alexandra Borovova [:Sasha]]

Ok, as we discovered the issue is that because we attach the locale override to the JSRuntime, which is shared inside the process, the locale override becomes also shared across the browsing contexts which share the same process.
The solution proposed by SpiderMonkey folks is to attach the override to Realm instead, since Realm is unique for browsing contexts.

Comment 5

[Alexandra Borovova [:Sasha]]

Attachment: Bug 1980211 - [bidi] Remove workaround to do an extra roundrip for newly created cross-origin iframes.

Comment 6

[Alexandra Borovova [:Sasha]]

Attachment: Bug 1980211 - [wdspec] Add tests for locale override in sandboxes.

Comment 8

[BugBot [:suhaib / :marco/ :calixte]]

The severity field is not set for this bug.
:whimboo, could you have a look please?

For more information, please visit BugBot documentation.

Comment 9

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/79c6fe2728e6
https://hg.mozilla.org/integration/autoland/rev/33dcf5c2e643
Attach locale override to Realm instead of setting it in the process. r=dom-core,smaug,tschuster
https://github.com/mozilla-firefox/firefox/commit/ab8a5f4e5613
https://hg.mozilla.org/integration/autoland/rev/e33f7c53a1a1
[bidi] Remove workaround to do an extra roundrip for newly created cross-origin iframes. r=webdriver-reviewers,jdescottes
https://github.com/mozilla-firefox/firefox/commit/871afacccf6c
https://hg.mozilla.org/integration/autoland/rev/3a43f9238e35
[wdspec] Fix "another_locale" fixture. r=webdriver-reviewers,jdescottes
https://github.com/mozilla-firefox/firefox/commit/a8c4b93f08ab
https://hg.mozilla.org/integration/autoland/rev/7cf969f76172
Add gecko specific test to verify that locale override is isolated inside browsing context. r=webdriver-reviewers,jdescottes
https://github.com/mozilla-firefox/firefox/commit/5b5bc02501d6
https://hg.mozilla.org/integration/autoland/rev/13bba316b2eb
[wdspec] Add tests for locale override in sandboxes. r=webdriver-reviewers,jdescottes

Comment 10

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Created web-platform-tests PR https://github.com/web-platform-tests/wpt/pull/54421 for changes under testing/web-platform/tests

Comment 11

[Iulian Moraru]

https://hg.mozilla.org/mozilla-central/rev/33dcf5c2e643
https://hg.mozilla.org/mozilla-central/rev/e33f7c53a1a1
https://hg.mozilla.org/mozilla-central/rev/3a43f9238e35
https://hg.mozilla.org/mozilla-central/rev/7cf969f76172
https://hg.mozilla.org/mozilla-central/rev/13bba316b2eb

Comment 12

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Upstream PR merged by moz-wptsync-bot