1980215 - Support `::before::marker` and `::after::marker`

Status: RESOLVED FIXED

(Core :: Layout: Generated Content, Lists, and Counters, enhancement)

Comment 1

[Keith Cirkel [:keithamus]]

https://github.com/mozilla/standards-positions/issues/1109

Comment 2

[Keith Cirkel [:keithamus]]

Attachment: Bug 1980215 - Support parsing of `::before::marker`,`::after::marker` r?emilio,#dom-core

Comment 3

[Sebastian Zartner [:sebo]]

Support for nesting those pseudo-elements should be documented, at least in the related BCD but probably also at https://developer.mozilla.org/en-US/docs/Web/CSS/::marker.

Sebastian

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/b29eacf47442
https://hg.mozilla.org/integration/autoland/rev/410a08e6f392
Support parsing of `::before::marker`,`::after::marker` r=emilio,firefox-style-system-reviewers

Comment 5

[Cristian Tuns]

https://hg.mozilla.org/mozilla-central/rev/410a08e6f392

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/c3a6645b6ffd
https://hg.mozilla.org/integration/autoland/rev/be5dc3d9c2b9
Support parsing of `::before::marker`,`::after::marker` r=emilio,firefox-style-system-reviewers

Comment 7

[Keith Cirkel [:keithamus]]

(In reply to Sebastian Zartner [:sebo] from comment #3)

Support for nesting those pseudo-elements should be documented, at least in the related BCD but probably also at https://developer.mozilla.org/en-US/docs/Web/CSS/::marker.

Sebastian

It's documented in ::before: https://developer.mozilla.org/en-US/docs/Web/CSS/::before#beforemarker_nested_pseudo-elements. I am unsure if that negates the need for it to be documented in ::marker, so I'll leave dev-doc-needed and let you decide on whether or not we need to add more there.

Comment 8

[Oriol Brufau [:Oriol]]

This is closed but /css/css-lists/nested-marker-styling.html is still failing?

Comment 9

[Emilio Cobos Álvarez [:emilio]]

Is it worth reopening? nested-marker-styling is fixed by bug 1954142 (as expected)

Comment 10

[Keith Cirkel [:keithamus]]

I figured I'd re-open for now and re-close as https://bugzilla.mozilla.org/show_bug.cgi?id=1954142 & D254456 land in main, so we can be sure we're fully done.

Comment 11

[Keith Cirkel [:keithamus]]

Shame that we cannot have circular issue references, this both blocks and depends on 1954142 😆

Comment 12

[agoloman]

Backed out for causing multiple wr failures.

• Backout link
• Push with failures
• Failure Log

Comment 13

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/628f5660d7ae
https://hg.mozilla.org/integration/autoland/rev/43f22436f30c
Support parsing of `::before::marker`,`::after::marker` r=emilio,firefox-style-system-reviewers

Comment 14

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/35b8a466f494
https://hg.mozilla.org/integration/autoland/rev/4947d19f3fbe
details-pseudo-elements-005 also fails on macOS

Comment 15

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/61c0760a02df
https://hg.mozilla.org/integration/autoland/rev/a55bb876d00f
details-pseudo-elements-005 also fails on Android.

Comment 16

[Cristina Horotan [:chorotan]]

https://hg.mozilla.org/mozilla-central/rev/be5dc3d9c2b9
https://hg.mozilla.org/mozilla-central/rev/43f22436f30c
https://hg.mozilla.org/mozilla-central/rev/4947d19f3fbe
https://hg.mozilla.org/mozilla-central/rev/a55bb876d00f

Comment 17

[Sebastian Zartner [:sebo]]

(In reply to Keith Cirkel [:keithamus] from comment #7)

(In reply to Sebastian Zartner [:sebo] from comment #3)

Support for nesting those pseudo-elements should be documented, at least in the related BCD but probably also at https://developer.mozilla.org/en-US/docs/Web/CSS/::marker.

Sebastian

It's documented in ::before: https://developer.mozilla.org/en-US/docs/Web/CSS/::before#beforemarker_nested_pseudo-elements. I am unsure if that negates the need for it to be documented in ::marker, so I'll leave dev-doc-needed and let you decide on whether or not we need to add more there.

Thanks for the hint! And it's also documented in ::after, which is good. Though the fact that I expected it to be documented at ::marker speaks for adding a note there, too.
In any case, the dev-doc-needed is also required to update the browser compat data (for ::marker, ::before, and ::after). So it's good you kept it.

Sebastian

Comment 18

[Dave Letorey]

Associated Pull Requests

• BCD PR
• Firefox Release PR