1980240 - Move drag and drop code out of tabs.js

Status: RESOLVED FIXED

(Firefox :: Tabbed Browser, task, P2)

Description

[Kelly Cochrane [:kcochrane]]

See this document for discussion. In an effort to cleanup browser/components/tabbrowser/content/tabs.js, we should move drag and drop code to a new module. This will hopefully cut down on some of some of the added complexity that was introduced when drag to pin logic was added recently and give us a space for adding more drag and drop logic required for upcoming split view work. We can address things like performance and potential reusability in follow-ups if needed, so this task should only involve moving things out of tabs.js.

Comment 1

[Nikki Sharpley (:nikkis) (she/her)]

Attachment: Bug 1980240 - Refactor tabs drag and drop code into its own module

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/6eba5941aef8
https://hg.mozilla.org/integration/autoland/rev/c549fa98031e
Refactor tabs drag and drop code into its own module r=tabbrowser-reviewers,sthompson

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/793e275c005a
https://hg.mozilla.org/integration/autoland/rev/7adb77be718a
Revert "Bug 1980240 - Refactor tabs drag and drop code into its own module r=tabbrowser-reviewers,sthompson" for causing bc failures @ browser_tabdetach.js

Comment 4

[Sandor Molnar[:smolnar]]

Backed out for causing bc failures @ browser_tabdetach.js

Backout link: https://hg.mozilla.org/integration/autoland/rev/7adb77be718a4b4023f2f573d9ee832b1da8153c

Push with failures

Failure log -> TEST-UNEXPECTED-FAIL | browser/base/content/test/performance/browser_tabdetach.js | Unused expected reflow at clientPos@chrome://browser/content/tabbrowser/tabs.js:

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/0866f240d403
https://hg.mozilla.org/integration/autoland/rev/0a8ecedb875b
Refactor tabs drag and drop code into its own module r=tabbrowser-reviewers,sthompson

Comment 6

[Narcis Beleuzu [:NarcisB]]

https://hg.mozilla.org/mozilla-central/rev/0a8ecedb875b