1980312 - Perma [tier 2] mingw /builds/worker/checkouts/gecko/browser/app/desktop-launcher/download_firefox.cpp:227:30: error: use of undeclared identifier 'WINHTTP_FLAG_SECURE_DEFAULTS'

Status: RESOLVED FIXED

(Firefox :: Installer, defect, P3)

Description

[Treeherder Bug Filer]

Filed by: chorotan [at] mozilla.com
Parsed log: https://treeherder.mozilla.org/logviewer?job_id=520246640&repo=autoland
Full log: https://firefox-ci-tc.services.mozilla.com/api/queue/v1/task/dbWcK5FTSmmxSatIbzxOlg/runs/0/artifacts/public/logs/live_backing.log

---

[task 2025-07-30T23:30:19.172+00:00] 23:30:19     INFO -  /builds/worker/fetches/sccache/sccache /builds/worker/fetches/clang/bin/x86_64-w64-mingw32-clang++ -o Unified_cpp_desktop-launcher0.o -c  -U_FORTIFY_SOURCE -D_FORTIFY_SOURCE=2 -D_LIBCPP_HARDENING_MODE=_LIBCPP_HARDENING_MODE_DEBUG -fstack-protector-strong -ftrivial-auto-var-init=pattern -fstrict-flex-arrays=1 -DDEBUG=1 -DMOZ_BRANDING_IS_NIGHTLY=1 '-DFIREFOX_ICO="/builds/worker/checkouts/gecko/browser/branding/nightly/firefox.ico"' -I/builds/worker/checkouts/gecko/browser/app/desktop-launcher -I/builds/worker/workspace/obj-build/browser/app/desktop-launcher -I/builds/worker/checkouts/gecko/toolkit/xre -I/builds/worker/workspace/obj-build/dist/include -I/builds/worker/workspace/obj-build/dist/include/nspr -I/builds/worker/workspace/obj-build/dist/include/nss -DMOZILLA_CLIENT -include /builds/worker/workspace/obj-build/mozilla-config.h -Wno-incompatible-ms-struct -fno-rtti -fno-sized-deallocation -fno-aligned-new -ffunction-sections -fdata-sections -fno-math-errno -fno-exceptions -D_HAS_EXCEPTIONS=0 -fms-extensions -fcrash-diagnostics-dir=/builds/worker/artifacts -include _mingw.h -g -gcodeview -O2 -fno-omit-frame-pointer -funwind-tables -Wall -Wbitfield-enum-conversion -Wempty-body -Wformat-type-confusion -Wignored-qualifiers -Wpointer-arith -Wshadow-field-in-constructor-modified -Wsign-compare -Wtautological-constant-in-range-compare -Wtype-limits -Wno-error=tautological-type-limit-compare -Wunreachable-code -Wunreachable-code-return -Wunused-but-set-parameter -Wno-invalid-offsetof -Wclass-varargs -Wempty-init-stmt -Wfloat-overflow-conversion -Wfloat-zero-conversion -Wloop-analysis -Wno-range-loop-analysis -Wenum-compare-conditional -Wenum-float-conversion -Wno-deprecated-anon-enum-enum-conversion -Wno-deprecated-enum-enum-conversion -Wno-deprecated-this-capture -Wcomma -Wimplicit-fallthrough -Wstring-conversion -Wno-inline-new-delete -Wno-error=deprecated-declarations -Wno-error=array-bounds -Wno-error=free-nonheap-object -Wno-error=atomic-alignment -Wno-error=deprecated-builtins -Wno-unknown-pragmas -Wno-unused-function -Wno-conversion-null -Wno-switch -Wno-enum-compare -Wno-psabi -Wthread-safety -Wno-error=builtin-macro-redefined -Wno-vla-cxx-extension -Wno-unknown-warning-option -fno-strict-aliasing -ffp-contract=off  -MD -MP -MF .deps/Unified_cpp_desktop-launcher0.o.pp   Unified_cpp_desktop-launcher0.cpp
[task 2025-07-30T23:30:19.173+00:00] 23:30:19     INFO -  In file included from Unified_cpp_desktop-launcher0.cpp:2:
[task 2025-07-30T23:30:19.173+00:00] 23:30:19    ERROR -  /builds/worker/checkouts/gecko/browser/app/desktop-launcher/download_firefox.cpp:227:30: error: use of undeclared identifier 'WINHTTP_FLAG_SECURE_DEFAULTS'
[task 2025-07-30T23:30:19.173+00:00] 23:30:19     INFO -    227 |                   is_https ? WINHTTP_FLAG_SECURE_DEFAULTS : WINHTTP_FLAG_ASYNC);
[task 2025-07-30T23:30:19.173+00:00] 23:30:19     INFO -        |                              ^
[task 2025-07-30T23:30:19.174+00:00] 23:30:19     INFO -  1 error generated.
[task 2025-07-30T23:30:19.174+00:00] 23:30:19    ERROR -  gmake[4]: *** [/builds/worker/checkouts/gecko/config/rules.mk:676: Unified_cpp_desktop-launcher0.o] Error 1
[task 2025-07-30T23:30:19.174+00:00] 23:30:19     INFO -  gmake[4]: Leaving directory '/builds/worker/workspace/obj-build/browser/app/desktop-launcher'
[task 2025-07-30T23:30:19.174+00:00] 23:30:19     INFO -  gmake[4]: Target 'target-objects' not remade because of errors.
[task 2025-07-30T23:30:19.175+00:00] 23:30:19    ERROR -  gmake[3]: *** [/builds/worker/checkouts/gecko/config/recurse.mk:72: browser/app/desktop-launcher/target-objects] Error 2
[task 2025-07-30T23:30:19.197+00:00] 23:30:19     INFO -  gmake[4]: Entering directory '/builds/worker/workspace/obj-build/gfx/angle/targets/libEGL'
[task 2025-07-30T23:30:19.197+00:00] 23:30:19     INFO -  mkdir -p '.deps/'
[task 2025-07-30T23:30:19.197+00:00] 23:30:19     INFO -  gmake[4]: Leaving directory '/builds/worker/workspace/obj-build/gfx/angle/targets/libEGL'
[task 2025-07-30T23:30:19.219+00:00] 23:30:19     INFO -  gmake[4]: Entering directory '/builds/worker/workspace/obj-build/gfx/angle/targets/libEGL'
[task 2025-07-30T23:30:19.219+00:00] 23:30:19     INFO -  gfx/angle/targets/libEGL/egl_loader_autogen.o
[task 2025-07-30T23:30:19.219+00:00] 23:30:19     INFO -  gmake[4]: Leaving directory '/builds/worker/workspace/obj-build/gfx/angle/targets/libEGL'
[task 2025-07-30T23:30:19.236+00:00] 23:30:19     INFO -  gmake[4]: Entering directory '/builds/worker/workspace/obj-build/config/external/wasm2c_sandbox_compiler'
[task 2025-07-30T23:30:19.237+00:00] 23:30:19     INFO -  /builds/worker/fetches/sccache/sccache /builds/worker/fetches/clang/bin/clang++ --sysroot /builds/worker/fetches/sysroot-x86_64-linux-gnu -o host_binary-writer.o -c -DXP_UNIX -O3 -DDEBUG=1 -Wno-implicit-fallthrough -I/builds/worker/checkouts/gecko/config/external/wasm2c_sandbox_compiler -I/builds/worker/workspace/obj-build/config/external/wasm2c_sandbox_compiler -I/builds/worker/checkouts/gecko/third_party/picosha2 -I/builds/worker/checkouts/gecko/third_party/wasm2c/include -I/builds/worker/workspace/obj-build/dist/include -MD -MP -MF .deps/host_binary-writer.o.pp -I/builds/worker/workspace/obj-build/dist/include/nspr /builds/worker/checkouts/gecko/third_party/wasm2c/src/binary-writer.cc
[task 2025-07-30T23:30:19.237+00:00] 23:30:19     INFO -  gmake[4]: Leaving directory '/builds/worker/workspace/obj-build/config/external/wasm2c_sandbox_compiler'
[task 2025-07-30T23:30:19.245+00:00] 23:30:19     INFO -  gmake[4]: Entering directory '/builds/worker/workspace/obj-build/config/external/wasm2c_sandbox_compiler'
[task 2025-07-30T23:30:19.245+00:00] 23:30:19     INFO -  gmake[4]: Leaving directory '/builds/worker/workspace/obj-build/config/external/wasm2c_sandbox_compiler'
[task 2025-07-30T23:30:19.246+00:00] 23:30:19     INFO -  gmake[4]: Entering directory '/builds/worker/workspace/obj-build/config/external/wasm2c_sandbox_compiler'
[task 2025-07-30T23:30:19.247+00:00] 23:30:19     INFO -  config/external/wasm2c_sandbox_compiler/host_binding-hash.o
[task 2025-07-30T23:30:19.247+00:00] 23:30:19     INFO -  gmake[4]: Leaving directory '/builds/worker/workspace/obj-build/config/external/wasm2c_sandbox_compiler'
[task 2025-07-30T23:30:19.272+00:00] 23:30:19     INFO -  gmake[4]: Entering directory '/builds/worker/workspace/obj-build/config/external/wasm2c_sandbox_compiler'
[task 2025-07-30T23:30:19.273+00:00] 23:30:19     INFO -  /builds/worker/fetches/sccache/sccache /builds/worker/fetches/clang/bin/clang++ --sysroot /builds/worker/fetches/sysroot-x86_64-linux-gnu -o host_binary.o -c -DXP_UNIX -O3 -DDEBUG=1 -Wno-implicit-fallthrough -I/builds/worker/checkouts/gecko/config/external/wasm2c_sandbox_compiler -I/builds/worker/workspace/obj-build/config/external/wasm2c_sandbox_compiler -I/builds/worker/checkouts/gecko/third_party/picosha2 -I/builds/worker/checkouts/gecko/third_party/wasm2c/include -I/builds/worker/workspace/obj-build/dist/include -MD -MP -MF .deps/host_binary.o.pp -I/builds/worker/workspace/obj-build/dist/include/nspr /builds/worker/checkouts/gecko/third_party/wasm2c/src/binary.cc
[task 2025-07-30T23:30:19.273+00:00] 23:30:19     INFO -  gmake[4]: Leaving directory '/builds/worker/workspace/obj-build/config/external/wasm2c_sandbox_compiler'
[task 2025-07-30T23:30:19.274+00:00] 23:30:19     INFO -  gmake[4]: Entering directory '/builds/worker/workspace/obj-build/config/external/wasm2c_sandbox_compiler'
[task 2025-07-30T23:30:19.275+00:00] 23:30:19     INFO -  gmake[4]: Leaving directory '/builds/worker/workspace/obj-build/config/external/wasm2c_sandbox_compiler'
[task 2025-07-30T23:30:19.288+00:00] 23:30:19     INFO -  gmake[4]: Entering directory '/builds/worker/workspace/obj-build/config/external/wasm2c_sandbox_compiler'
[task 2025-07-30T23:30:19.288+00:00] 23:30:19     INFO -  config/external/wasm2c_sandbox_compiler/host_c-writer.o
[task 2025-07-30T23:30:19.288+00:00] 23:30:19     INFO -  gmake[4]: Leaving directory '/builds/worker/workspace/obj-build/config/external/wasm2c_sandbox_compiler'
[task 2025-07-30T23:30:19.289+00:00] 23:30:19     INFO -  gmake[4]: Entering directory '/builds/worker/workspace/obj-build/security/sandbox'
[task 2025-07-30T23:30:19.290+00:00] 23:30:19     INFO -  /builds/worker/fetches/sccache/sccache /builds/worker/fetches/clang/bin/x86_64-w64-mingw32-clang++ -o logging.o -c  -U_FORTIFY_SOURCE -D_FORTIFY_SOURCE=2 -D_LIBCPP_HARDENING_MODE=_LIBCPP_HARDENING_MODE_DEBUG -fstack-protector-strong -ftrivial-auto-var-init=pattern -fstrict-flex-arrays=1 -DDEBUG=1 -DUNICODE -D_UNICODE -DNS_NO_XPCOM -D_CRT_RAND_S -DCHROMIUM_SANDBOX_BUILD -I/builds/worker/checkouts/gecko/security/sandbox -I/builds/worker/workspace/obj-build/security/sandbox -I/builds/worker/checkouts/gecko/security/sandbox/chromium-shim -I/builds/worker/checkouts/gecko/security/sandbox/chromium -I/builds/worker/checkouts/gecko/security/sandbox/chromium-shim/base/allocator/partition_allocator/src -I/builds/worker/checkouts/gecko/security/sandbox/chromium/base/allocator/partition_allocator/src -I/builds/worker/checkouts/gecko/third_party/abseil-cpp -I/builds/worker/checkouts/gecko/nsprpub -I/builds/worker/workspace/obj-build/dist/include -I/builds/worker/workspace/obj-build/dist/include/nspr -I/builds/worker/workspace/obj-build/dist/include/nss -DMOZILLA_CLIENT -include /builds/worker/workspace/obj-build/mozilla-config.h -Wno-incompatible-ms-struct -fno-rtti -fno-sized-deallocation -fno-aligned-new -ffunction-sections -fdata-sections -fno-math-errno -fno-exceptions -D_HAS_EXCEPTIONS=0 -fms-extensions -fcrash-diagnostics-dir=/builds/worker/artifacts -include _mingw.h -g -gcodeview -O2 -fno-omit-frame-pointer -funwind-tables -Wall -Wbitfield-enum-conversion -Wempty-body -Wformat-type-confusion -Wignored-qualifiers -Wpointer-arith -Wshadow-field-in-constructor-modified -Wsign-compare -Wtautological-constant-in-range-compare -Wtype-limits -Wno-error=tautological-type-limit-compare -Wunreachable-code -Wunreachable-code-return -Wunused-but-set-parameter -Wno-invalid-offsetof -Wclass-varargs -Wempty-init-stmt -Wfloat-overflow-conversion -Wfloat-zero-conversion -Wloop-analysis -Wno-range-loop-analysis -Wenum-compare-conditional -Wenum-float-conversion -Wno-deprecated-anon-enum-enum-conversion -Wno-deprecated-enum-enum-conversion -Wno-deprecated-this-capture -Wcomma -Wimplicit-fallthrough -Wstring-conversion -Wno-inline-new-delete -Wno-error=deprecated-declarations -Wno-error=array-bounds -Wno-error=free-nonheap-object -Wno-error=atomic-alignment -Wno-error=deprecated-builtins -Wno-unknown-pragmas -Wno-unused-function -Wno-conversion-null -Wno-switch -Wno-enum-compare -Wno-psabi -Wthread-safety -Wno-error=builtin-macro-redefined -Wno-vla-cxx-extension -Wno-unknown-warning-option -fno-strict-aliasing -ffp-contract=off  -MD -MP -MF .deps/logging.o.pp   /builds/worker/checkouts/gecko/security/sandbox/chromium-shim/base/logging.cpp
[task 2025-07-30T23:30:19.291+00:00] 23:30:19     INFO -  In file included from <built-in>:1:
[task 2025-07-30T23:30:19.291+00:00] 23:30:19     INFO -  In file included from /builds/worker/workspace/obj-build/mozilla-config.h:203:
[task 2025-07-30T23:30:19.291+00:00] 23:30:19  WARNING -  /builds/worker/checkouts/gecko/security/sandbox/chromium-shim/base/win/sdkdecls.h:21:9: warning: 'PROCESS_CREATION_MITIGATION_POLICY_FONT_DISABLE_MASK' macro redefined [-Wmacro-redefined]
[task 2025-07-30T23:30:19.291+00:00] 23:30:19     INFO -     21 | #define PROCESS_CREATION_MITIGATION_POLICY_FONT_DISABLE_MASK                              (0x00000003uLL << 48)
[task 2025-07-30T23:30:19.292+00:00] 23:30:19     INFO -        |         ^
[task 2025-07-30T23:30:19.292+00:00] 23:30:19     INFO -  /builds/worker/fetches/clang/bin/../x86_64-w64-mingw32/include/winbase.h:1862:9: note: previous definition is here
[task 2025-07-30T23:30:19.292+00:00] 23:30:19     INFO -   1862 | #define PROCESS_CREATION_MITIGATION_POLICY_FONT_DISABLE_MASK (0x0003ULL << 48)
[task 2025-07-30T23:30:19.292+00:00] 23:30:19     INFO -        |         ^
[task 2025-07-30T23:30:19.292+00:00] 23:30:19     INFO -  In file included from <built-in>:1:
[task 2025-07-30T23:30:19.292+00:00] 23:30:19     INFO -  In file included from /builds/worker/workspace/obj-build/mozilla-config.h:203:
[task 2025-07-30T23:30:19.292+00:00] 23:30:19  WARNING -  /builds/worker/checkouts/gecko/security/sandbox/chromium-shim/base/win/sdkdecls.h:22:9: warning: 'PROCESS_CREATION_MITIGATION_POLICY_FONT_DISABLE_DEFER' macro redefined [-Wmacro-redefined]
[task 2025-07-30T23:30:19.293+00:00] 23:30:19     INFO -     22 | #define PROCESS_CREATION_MITIGATION_POLICY_FONT_DISABLE_DEFER                             (0x00000000uLL << 48)
[task 2025-07-30T23:30:19.293+00:00] 23:30:19     INFO -        |         ^
[task 2025-07-30T23:30:19.293+00:00] 23:30:19     INFO -  /builds/worker/fetches/clang/bin/../x86_64-w64-mingw32/include/winbase.h:1863:9: note: previous definition is here
[task 2025-07-30T23:30:19.293+00:00] 23:30:19     INFO -   1863 | #define PROCESS_CREATION_MITIGATION_POLICY_FONT_DISABLE_DEFER (0x0000ULL << 48)
[task 2025-07-30T23:30:19.293+00:00] 23:30:19     INFO -        |         ^
[task 2025-07-30T23:30:19.293+00:00] 23:30:19     INFO -  In file included from <built-in>:1:
[task 2025-07-30T23:30:19.294+00:00] 23:30:19     INFO -  In file included from /builds/worker/workspace/obj-build/mozilla-config.h:203:
[task 2025-07-30T23:30:19.294+00:00] 23:30:19  WARNING -  /builds/worker/checkouts/gecko/security/sandbox/chromium-shim/base/win/sdkdecls.h:23:9: warning: 'PROCESS_CREATION_MITIGATION_POLICY_FONT_DISABLE_ALWAYS_ON' macro redefined [-Wmacro-redefined]
[task 2025-07-30T23:30:19.294+00:00] 23:30:19     INFO -     23 | #define PROCESS_CREATION_MITIGATION_POLICY_FONT_DISABLE_ALWAYS_ON                         (0x00000001uLL << 48)

Comment 1

[BugBot [:suhaib / :marco/ :calixte]]

Set release status flags based on info from the regressing bug 1968279

:cdupuis, since you are the author of the regressor, bug 1968279, could you take a look? Also, could you set the severity field?

For more information, please visit BugBot documentation.

Comment 2

[Chris DuPuis]

This component can be excluded from mingw builds. I'm taking a look at how to do this.

Comment 3

[Chris DuPuis]

Attachment: Bug 1980312 - Exclude desktop-launcher from mingw builds r=nrishel

WinHTTP headers are not available in MinGW, but they are needed
by this feature. Disabling it on mingw.

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/e41c8982d0f2
https://hg.mozilla.org/integration/autoland/rev/9ab5065c866f
Exclude desktop-launcher from mingw builds r=nrishel

Comment 5

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

https://hg.mozilla.org/mozilla-central/rev/9ab5065c866f

Comment 6

[Intermittent Failures Robot]

17 failures were associated with this bug in the last 7 days.

Repository breakdown:

• mozilla-central: 12
• autoland: 5

Table

	no_variant
linux-x86/debug	9
linux-x86/opt	8

For more details, see:

https://treeherder.mozilla.org/intermittent-failures/bugdetails?bug=1980312&startday=2025-07-28&endday=2025-08-03&tree=all

Comment 7

[Florin Bilt]

(In reply to Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout) from comment #5)

https://hg.mozilla.org/mozilla-central/rev/9ab5065c866f

Perfherder has detected a build_metrics performance change from push 9ab5065c866fde8101bef96c9a89dfc293511f14.

If you have any questions, please reach out to a performance sheriff. Alternatively, you can find help on Slack by joining #perf-help, and on Matrix you can find help by joining #perftest.

Improvements:

Ratio	Test	Platform	Options	Absolute values (old vs new)
0.17%	installer size	windows2012-64		122,436,891.79 -> 122,230,193.75

Details of the alert can be found in the alert summary, including links to graphs and comparisons for each of the affected tests.

If you need the profiling jobs you can trigger them yourself from treeherder job view or ask a performance sheriff to do that for you.

You can run all of these tests on try with ./mach try perf --alert 46124

The following documentation link provides more information about this command.