1980364 - Taskbar Tab window icon only changes after closing and re-launching the Taskbar Tab

Status: VERIFIED FIXED

(Firefox :: Shell Integration, defect, P3)

Description

[Alex Cornestean]

Attachment: grouped.mp4

Affected Version:
Nightly - 143.0a1/20250730213201
Beta – 142.0b5/20250730090632

Description:

For grouped taskbar items:
Upon creating a Taskbar Tab, the taskbar item and the new window will have a generic icon. The taskbar item icon will be replaced by the website favicon once the Taskbar Tab is pinned to the taskbar.
However, checking the window icon via cycling through open windows with Alt+Tab or hovering over the Taskbar Tab on the taskbar reveals that the window icon is still the generic one. Only after closing and re-launching the Taskbar Tab will the window icon switch to the favicon of the website.

For ungrouped taskbar items:
Upon creating a Taskbar Tab, the taskbar item as well as the window will have a generic icon. Pinning it will still not change the icon of the taskbar item to the one of the website but remain the generic one.
Closing the Taskbar Tab will immediately cause the icon of the Taskbar Tab on the taskbar to change to the icon of the website. This will also cause the icon of the Taskbar Tab window to get updated to the favicon of the website once the Taskbar Tab launches.

Grouped behavior steps to reproduce:

1. Create a Taskbar Tab via the pageAction
2. Notice the generic icon for the Taskbar Tab
3. Pin the Taskbar Tab when notified
4. Notice the icon of the Taskbar Tab on the taskbar changes from the generic one to the icon of the website upon pinning
5. Alt+Tab to cycle through the open windows and notice the icon of the Taskbar Tab window is still the generic one. Alternatively, hover over the pinned Taskbar Tab on the taskbar and notice the generic icon of the Taskbar Tab window
6. Close the Taskbar Tab window and re-launch it
7. Alt+Tab to cycle through the open windows and notice the icon of the Taskbar Tab window is now the favicon of the website. Alternatively, hover over the pinned Taskbar Tab on the taskbar and notice the icon of the Taskbar Tab window is now the favicon of the website

Ungrouped behavior steps to reproduce:

Prerequisites: Change the grouping behavior of items on the taskbar by following the guide here https://learn.microsoft.com/en-us/answers/questions/1473926/ungroup-icons-at-windows-11-taskbar.

1. Create a Taskbar Tab via the pageAction
2. Notice the generic icon for the Taskbar Tab
3. Pin the Taskbar Tab when notified
4. Notice the icon of the Taskbar Tab taskbar item has not changed to the favicon of the website, but remains the generic one
5. Alt+Tab to cycle through the open windows and notice the icon of the Taskbar Tab window is still the generic one. Alternatively, hover over the pinned Taskbar Tab on the taskbar and notice the generic icon of the Taskbar Tab window
6. Close the Taskbar Tab window
7. Notice the icon of the Taskbar Tab taskbar item immediately changes to the favicon of the website
8. Launch the Taskbar Tab
9. Alt+Tab to cycle through the open windows and notice the icon of the Taskbar Tab window is now the favicon of the website. Alternatively, hover over the pinned Taskbar Tab on the taskbar and notice the icon of the Taskbar Tab window is now the favicon of the website

Actual results:

1. For the grouped behavior, the Taskbar Tab window icon changes only after closing/re-launching the Taskbar Tab
2. For the ungrouped behavior, when the Taskbar Tab is created, both the taskbar item icon and the window icon remain the generic icon. The Taskbar Tab taskbar icon does not update after pinning, but only after closing the Taskbar Tab window. Once re-launched both the Taskbar Tab window icon is updated to the favicon of the website.

Expected results:
The Taskbar Tab should be created with the favicon of the website for both the taskbar icon and the window icon.

Comment 1

[Alex Cornestean]

Attachment: ungrouped.mp4

Comment 2

[Nick Rishel [:nrishel]]

Copying my comment from the other bug:

The behavior differs between grouped vs ungrouped taskbar icons, the latter doesn't update until a new window is created and the former updates once pinned, indicating there's an issue with setting the window icon the first time. This issue didn't reproduce in a debug build, so this is probably a race.

Comment 3

[Nick Rishel [:nrishel]]

Going to land a quick fix in Beta, leave open to follow up on a proper fix.

Comment 4

[Nick Rishel [:nrishel]]

Attachment: Bug 1980364 - Add a delay to reduce chance of a race between pinning and window icon reading from favicon service.

This is a temporary fix to prevent delaying experimentation.

Comment 5

[Phabricator Automation]

firefox-beta Uplift Approval Request

• User impact if declined: Image setting to the default image in Taskbar Tabs experiment, confusing results.
• Code covered by automated testing: yes
• Fix verified in Nightly: yes
• Needs manual QE test: yes
• Steps to reproduce for manual QE testing: STR in bug.
• Risk associated with taking this patch: Low
• Explanation of risk level: Only adds a brief delay to trigger a Web App to pin. Existing code already has a several second delay.
• String changes made/needed: n/a
• Is Android affected?: no

Comment 6

[Nick Rishel [:nrishel]]

Attachment: Bug 1980364 - Add a delay to reduce chance of a race between pinning and window icon reading from favicon service. r=dmcintosh

This is a temporary fix to prevent delaying experimentation.

Comment 7

[Dianna Smith [:diannaS]]

Comment on attachment 9504359 [details]
Bug 1980364 - Add a delay to reduce chance of a race between pinning and window icon reading from favicon service.

This failed to land and needs the patch rebased

Comment 8

[Pulsebot]

https://github.com/mozilla-firefox/firefox/commit/211775599275
https://hg.mozilla.org/releases/mozilla-beta/rev/8dab7be49347

Comment 9

[Nick Rishel [:nrishel]]

Attachment: Bug 1980364 - Don't reject images retrieved for Taskbar Tabs icons when the "error" is that it's cached. r=dmcintosh

This occurs due to our window icon and pin code retrieving the same image in parallel.

Comment 10

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/6c867b65f3d6
https://hg.mozilla.org/integration/autoland/rev/b906701cdeef
Don't reject images retrieved for Taskbar Tabs icons when the "error" is that it's cached. r=dmcintosh

Comment 11

[Cosmin Sabou [:CosminS]]

https://hg.mozilla.org/mozilla-central/rev/b906701cdeef

Comment 12

[Alex Cornestean]

I checked the bug as per the STR and it appears fixed on both the latest Nightly (144.0a1/20250824214058) and Beta (143.0b3/20250822090535).

As soon as a Taskbar Tab is created via the pageAction, the website icon is set for both the Taskbar Tab taskbar item and window, before the pinning notification is shown. This is true for both when taskbar items are grouped and ungrouped.

Based on the comments in the report, it appears the fix has landed in Nightly 143 and it rode the trains to Beta 143. However, I’m not entirely sure about this. I’m not going to change the status of the bug until I get confirmation that this is the case so I do not meddle in the triage process.

Comment 13

[Nick Rishel [:nrishel]]

:acornestean Should be resolved, leave-open was leftover from a prior hackier fix.

Comment 14

[Alex Cornestean]

:nrishel Thank you for confirming!

Based on my previous verification and comment (Comment 12), I’m setting this as Verified Fixed as the icon for both the Taskbar Tab taskbar item and window are set as soon as the Taskbar Tab is created.