1980513 - New wpt failures in /css/css-view-transitions/finished-promise-defers-cleanup.html

Status: RESOLVED FIXED

(Core :: CSS Parsing and Computation, defect)

Description

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Syncing wpt PR 54083 found new untriaged test failures in CI

Tests Affected

New Tests That Don't Pass

• /css/css-view-transitions/finished-promise-defers-cleanup.html [wpt.fyi]
  • View transition cleanup is deferred until after the frame where finished promise resolves: FAIL (Chrome: PASS, Safari: FAIL)

CI Results

Gecko CI (Treeherder)
GitHub PR Head

Notes

These updates will be on mozilla-central once bug 1980502 lands.

Note: this bug is for tracking fixing the issues and is not
owned by the wpt sync bot.

This bug is linked to the relevant tests by an annotation in
https://github.com/web-platform-tests/wpt-metadata. These annotations
can be edited using the wpt interop dashboard
https://jgraham.github.io/wptdash/

If this bug is split into multiple bugs, please also update the
annotations, otherwise we are unable to track which wpt issues are
already triaged. Resolving as duplicate or closing this issue should
be cause the bot to automatically update or remove the annotation.

Comment 2

[Emilio Cobos Álvarez [:emilio]]

Attachment: Bug 1980513 - Defer view-transition finished promise resolution as per CSSWG resolution. r=#vt,#dom-core

Note that the spec edits for
https://github.com/w3c/csswg-drafts/issues/12116 haven't happened yet,
but it's simple enough.

finished-promise-defers-cleanup.html was broken in multiple ways:

• It assumed that if there's no active transition position would be
  static, and such, which is just wrong. Safari agrees with us here,
  you generally can query random non-existent pseudo-element styles
  like ::first-line.

• There's a nicer way of doing this now that we expose
  document.activeViewTransition so test that too.

• Test that the ::view-transition pseudo is displayed by checking
  used-value properties like width, which depend on whether the
  pseudo-element actually exists.

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/be658e33f37f
https://hg.mozilla.org/integration/autoland/rev/01d76fffc640
Defer view-transition finished promise resolution as per CSSWG resolution. r=view-transitions-reviewers,boris

Comment 4

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Created web-platform-tests PR https://github.com/web-platform-tests/wpt/pull/57888 for changes under testing/web-platform/tests

Comment 5

[amarc]

https://hg.mozilla.org/mozilla-central/rev/01d76fffc640