Open Bug 1980558 Opened 9 months ago Updated 8 months ago

[meta] Add-on manager functionality has significant impact on start-up

Categories

(Toolkit :: Add-ons Manager, task, P3)

Unspecified
Android
task

Tracking

()

People

(Reporter: jlink, Unassigned)

References

(Depends on 3 open bugs, Blocks 2 open bugs)

Details

(Keywords: meta)

This comparison shows a significant improvement in numerous start/page-load metrics as a result of disabling add-on manager (aka extension manager) initialization.

newssite-applink-startup is a test that we've been looking at closely lately and it improves by ~8-14% with add-ons disabled. Various CPU time metrics also show dramatic reductions, likely due to some additional time savings that occur after the applink_startup metric is taken.

This was observed on Android specifically but it would make sense that there would be some impacts on other platforms as well.

Hi Justin,
could you share some more details about this meta bug and next steps related to it? e.g. Are you planning to attach new bugzilla issue to it and a GeckoProfiler data collected by running the newssite-applink-startup with and without the add-on manager or provide details about how to run the test locally so that we can collect GeckoProfiler data to look into?

Component: General → Add-ons Manager
Flags: needinfo?(jlink)
Product: WebExtensions → Toolkit

Yes - my apologies for the meta-bug with no linked bugs (yet). I will be creating two or three more specific bugs based on what Markus and I saw in some profiles. I will also grab some profiles from the comparison that I cite above and will post them here and take a also look myself to see if anything interesting jumps out at me.

If you want to run the same experiment locally (on whatever platform you are using) it was just a one-line change here so it should be simple to replicate.

Flags: needinfo?(jlink)
Depends on: 1981066
Summary: [meta] Add-on manager functionality has significant cost during start-up → [meta] Add-on manager functionality has significant impact on start-up
Severity: -- → N/A
Priority: -- → P3
Blocks: webext-perf

Is there a scenario where extensions should be completely skipped/ignored during startup, for app links?

Flags: needinfo?(jlink)

I'm not aware of any motivation to actually skip extensions during start-up. The reason for the initial experiment was just to quickly get an idea of what the total impact of extensions is (on start-up). Since the impact was pretty clear we decided that it was worth making a note of it and looking a bit closer and getting some more eyes on it. (We have a big focus for the year on reducing applink start-up time.)

Flags: needinfo?(jlink)
Blocks: 1983632
No longer blocks: 1983632
Depends on: 1983632
Depends on: 1984738
You need to log in before you can comment on or make changes to this bug.