1980648 - Win64 CFI epilog test fails

Status: RESOLVED FIXED

(Toolkit :: Crash Reporting, defect)

Description

[Alex Franchuk [:afranchuk]]

It's not clear whether this test ever passed, or whether this would have passed before the minidump analyzer rust rewrite (bug 1743983). We could go back and check the old minidump analyzer, but it may be a better use of time to try to fix the behavior in the new one.

Comment 1

[Alex Franchuk [:afranchuk]]

This has been fixed in https://github.com/mozilla/pe-unwind-info/commit/0e033103cb94e6f84a48db8634033837cafa764e. I verified that unwinding now works as expected using CFI information. Now there needs to be a new release of pe-unwind-info, then framehop, then minidump-unwind, and then we need to vendor the new version of minidump-unwind in-tree.

Comment 2

[Alex Franchuk [:afranchuk]]

Waiting on https://github.com/rust-minidump/rust-minidump/pull/1120.

Comment 3

[Alex Franchuk [:afranchuk]]

Waiting on a new version of minidump-unwind to be published.

Comment 4

[Alex Franchuk [:afranchuk]]

Gabriele, any chance we could get a new version of minidump-unwind published? There's no rush here, though.

Comment 5

[Gabriele Svelto [:gsvelto]]

I just cut a new release, sorry for the delay.

Comment 6

[Alex Franchuk [:afranchuk]]

This depends on bug 1975583 because the updated minidump crate uses usize::is_multiple_of, which is new in rust 1.87.

Comment 7

[Gabriele Svelto [:gsvelto]]

(In reply to Alex Franchuk [:afranchuk] from comment #6)

This depends on bug 1975583 because the updated minidump crate uses usize::is_multiple_of, which is new in rust 1.87.

Mmm, I didn't really think much about that. Maybe it's easier to roll it back and cut a patch release. WDYT?

Comment 8

[Alex Franchuk [:afranchuk]]

(In reply to Gabriele Svelto [:gsvelto] from comment #7)

(In reply to Alex Franchuk [:afranchuk] from comment #6)

This depends on bug 1975583 because the updated minidump crate uses usize::is_multiple_of, which is new in rust 1.87.

Mmm, I didn't really think much about that. Maybe it's easier to roll it back and cut a patch release. WDYT?

It would be convenient to get this bug closed, but there's no rush here.

Comment 9

[Alex Franchuk [:afranchuk]]

Attachment: Bug 1980648 - Update minidump-unwind to fix win64 CFI epilog processing r=gsvelto

Comment 10

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/79a5cdc7b7c9
https://hg.mozilla.org/integration/autoland/rev/aba7efab080d
Update minidump-unwind to fix win64 CFI epilog processing r=gsvelto,supply-chain-reviewers

Comment 11

[pstanciu]

https://hg.mozilla.org/mozilla-central/rev/aba7efab080d