1980686 - Use excludePartnerCodeFromTelemetry from search config in BrowserSearchTelemetry for sap.counts

Status: RESOLVED FIXED

(Firefox :: Search, task, P1)

Description

[Drew Willcoxon :adw]

In bug 1980474 we added an excludePartnerCodeFromTelemetry property to the URL config. We need to update the sap.counts logic in BrowserSearchTelemetry so that it checks it and excludes the partner code when it's true.

Comment 1

[Drew Willcoxon :adw]

Attachment: Bug 1980686 - Use excludePartnerCodeFromTelemetry from search config in BrowserSearchTelemetry for sap.counts.

This modifies the recording of sap.counts so that the partner code is excluded
when excludePartnerCodeFromTelemetryForURL is true. The update to legacy
SEARCH_COUNTS is still skipped when the source is contextmenu_visual, as
disucussed in https://phabricator.services.mozilla.com/D258653#inline-1422651

This doesn't change the reportPartnerCode logic if an unsupported
searchUrlType is passed in for the engine, i.e., if
engine.wrappedJSObject.getURLOfType returns nothing. It might make sense to
exclude the partner code then too, but I'm not sure it matters in practice?

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/7701adacef4f
https://hg.mozilla.org/integration/autoland/rev/16d6b254bd07
Use excludePartnerCodeFromTelemetry from search config in BrowserSearchTelemetry for sap.counts. r=Standard8

Comment 3

[[e-mail]]

https://hg.mozilla.org/mozilla-central/rev/16d6b254bd07