Closed Bug 1981037 Opened 7 months ago Closed 7 months ago

Change the EngineURL constructor to take an object/named parameters

Categories

(Firefox :: Search, task, P3)

Product:
Firefox
Component:
Search
Type:
task

Tracking

()

Status:
RESOLVED FIXED
Milestone:
143 Branch
Tracking Flags:
Tracking Status
firefox143 --- fixed

People

(Reporter: adw, Assigned: adw)

References

Details

(Whiteboard: [sng])

Attachments

(1 file)

Bug 1981037 - Change the EngineURL constructor to take an object/named parameters.
48 bytes, text/x-phabricator-request
Details | Review

We've recently added a few params to the EngineURL constructor as part of the visual search work, and it would be helpful to convert its params to an options object. Discussion here.

I took some liberties beyond simply converting the existing params to an options
object:

  • Renamed params so they have the same names as the corresponding engine
    properties (e.g., from base to template)
  • Made method default to "GET"
  • Updated callers so they use the splat operator where possible rather than
    specifying each param by name

Depends on D259668

Pushed by dwillcoxon@mozilla.com: https://github.com/mozilla-firefox/firefox/commit/33254b4fb57f https://hg.mozilla.org/integration/autoland/rev/b5b7604eb79a Change the EngineURL constructor to take an object/named parameters. r=Standard8

https://hg.mozilla.org/mozilla-central/rev/b5b7604eb79a

Status: ASSIGNED → RESOLVED
Closed: 7 months ago
status-firefox143: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 143 Branch
QA Whiteboard: [search] [qa-triage-done-c143/b142]
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: