Closed Bug 1981063 Opened 11 months ago Closed 8 months ago

Artifact exe search fix (Clone of Perma [Tier2] Diffoscope firefox differs. See the diff.html or diff.txt artifact | single tracking bug)

Categories

(Firefox :: Installer, defect)

defect

Tracking

()

RESOLVED FIXED
146 Branch
Tracking Status
firefox-esr128 --- unaffected
firefox-esr140 --- unaffected
firefox141 --- unaffected
firefox142 --- unaffected
firefox143 --- wontfix
firefox144 --- wontfix
firefox145 --- wontfix
firefox146 --- fixed

People

(Reporter: cdupuis, Assigned: cdupuis, NeedInfo)

References

(Regression)

Details

(Keywords: intermittent-failure, regression)

Attachments

(3 files, 1 obsolete file)

Filed by: smolnar [at] mozilla.com
Parsed log: https://treeherder.mozilla.org/logviewer?job_id=519881976&repo=autoland
Full log: https://firefox-ci-tc.services.mozilla.com/api/queue/v1/task/RUqVl2eQSfaJrHZT4_cAPg/runs/0/artifacts/public/logs/live_backing.log


 0%  …refox/vcruntime140_1.dll  ETA:  --:--:-- 
[task 2025-07-28T19:43:12.933+00:00]  |                          |    0%  b/firefox/wmfclearkey.dll  ETA:  --:--:-- 
[task 2025-07-28T19:43:13.043+00:00]  |                          |    0%          b/firefox/xul.dll  ETA:  --:--:-- 
[task 2025-07-28T19:43:13.043+00:00]  |                          |    0%                             ETA:  --:--:-- 
[task 2025-07-28T19:43:13.043+00:00]  |                          |    0%                             ETA:  --:--:-- 
[task 2025-07-28T19:43:13.043+00:00]  |                          |    0%                             ETA:  --:--:-- 
[task 2025-07-28T19:43:13.072+00:00]  |###########################|  100%                             Time: 0:00:15 
[task 2025-07-28T19:43:13.072+00:00] ++ dirname /builds/worker/bin/get_and_diffoscope
[task 2025-07-28T19:43:13.073+00:00] + /builds/worker/bin/report_error diff
[task 2025-07-28T19:43:13.082+00:00] TEST-UNEXPECTED-FAIL | firefox differs. See the diff.html or diff.txt artifact
[task 2025-07-28T19:43:13.084+00:00] + fail
[task 2025-07-28T19:43:13.084+00:00] + exit 1
[taskcluster 2025-07-28 19:43:15.924Z] === Task Finished ===
[taskcluster 2025-07-28 19:43:16.125Z] Unsuccessful task run with exit code: 1 completed in 54.511 second

A new desktop launcher .exe was added in the change for Bug 1968279.
Since it was added in a subdirectory of the main installation, the
current artifact logic was not finding it.

This change makes the artifact logic look in subdirectories for .exe
files, just as it does for .dll files.

https://bugzilla.mozilla.org/show_bug.cgi?id=1968279

Assignee: nobody → cdupuis
Status: NEW → ASSIGNED

Set release status flags based on info from the regressing bug 1968279

Status: ASSIGNED → RESOLVED
Closed: 11 months ago
Resolution: --- → FIXED
Target Milestone: --- → 143 Branch
Duplicate of this bug: 1979786

Failures are still piling up in bug 1981063, so this didn't fix the problem, apparently.

Status: RESOLVED → REOPENED
Resolution: FIXED → ---
Flags: needinfo?(cdupuis)

So, the problem is that DESKTOP_LAUNCHER_ENABLED is not defined when processing browser/installer/package-manifest.in in artifact builds.
But looking around for that define, I see a link to bug 1985118, which suggests the desktop-launcher shouldn't even be enabled in the first place, so we shouldn't even be talking about this bug?

There already are 111 failures in the last 7 days, are any updates?

with no action, I am going to submit a patch to disable this task as it is just burning CPU time.

:glandium, as you are concerned with my patch to disable, can you please work on fixing this bug? I don't understand why it is perma fail and no action on it for weeks.

Flags: needinfo?(mh+mozilla)
Attachment #9517879 - Attachment is obsolete: true
No longer depends on: 1979786
Pushed by mh@glandium.org: https://github.com/mozilla-firefox/firefox/commit/977d1ecafcd4 https://hg.mozilla.org/integration/autoland/rev/5c83443c834e Consistently enable desktop launcher in artifact vs. normal builds. r=firefox-build-system-reviewers,cdupuis,browser-installer-reviewers,sergesanspaille https://github.com/mozilla-firefox/firefox/commit/7c4c01f032d1 https://hg.mozilla.org/integration/autoland/rev/92a85f25f361 Remove unnecessary stanzas for desktop-launcher tests. r=firefox-build-system-reviewers,cdupuis,sergesanspaille
Status: REOPENED → RESOLVED
Closed: 11 months ago8 months ago
Resolution: --- → FIXED
Target Milestone: --- → 146 Branch
Regressions: 1995535
Regressions: 1995536
Regressions: 1995537
Pushed by chorotan@mozilla.com: https://github.com/mozilla-firefox/firefox/commit/35e99bf18424 https://hg.mozilla.org/mozilla-central/rev/008cce8390fa Revert "Bug 1981063 - Remove unnecessary stanzas for desktop-launcher tests. r=firefox-build-system-reviewers,cdupuis,sergesanspaille" for causing L10n bustages
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
Target Milestone: 146 Branch → ---
Pushed by mh@glandium.org: https://github.com/mozilla-firefox/firefox/commit/fea310fb940b https://hg.mozilla.org/integration/autoland/rev/03a8daa52b79 Consistently enable desktop launcher in artifact vs. normal builds. r=firefox-build-system-reviewers,cdupuis,browser-installer-reviewers,sergesanspaille https://github.com/mozilla-firefox/firefox/commit/882920db636f https://hg.mozilla.org/integration/autoland/rev/a60704405e23 Remove unnecessary stanzas for desktop-launcher tests. r=firefox-build-system-reviewers,cdupuis,sergesanspaille
Status: REOPENED → RESOLVED
Closed: 8 months ago8 months ago
Resolution: --- → FIXED
Target Milestone: --- → 146 Branch
Flags: needinfo?(mh+mozilla)
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: