Closed
Bug 1981304
Opened 1 year ago
Closed 1 year ago
More eagerly optimize linear gradient when dithering is enabled
Categories
(Core :: Graphics: WebRender, enhancement)
Core
Graphics: WebRender
Tracking
()
RESOLVED
FIXED
143 Branch
| Tracking | Status | |
|---|---|---|
| firefox143 | --- | fixed |
People
(Reporter: sotaro, Assigned: sotaro)
References
(Blocks 1 open bug)
Details
Attachments
(1 file)
When LinearGradient enables dithering, fast path is used only when color is same between 2 stops in LinearGradientTemplate::from().
By changing optimize_linear_gradient(), it is possible to increase it.
When there is no color change between 2 stops, dithering could be disabled.
| Assignee | ||
Comment 1•1 year ago
|
||
| Assignee | ||
Comment 2•1 year ago
|
||
D260094 seemed to reduce test failures.
https://treeherder.mozilla.org/jobs?repo=try&revision=bd454f0d12742e95578853daa0f4cc33756e351d
Updated•1 year ago
|
Attachment #9505368 -
Attachment description: WIP: Bug 1981304 - Use fast path more in LinearGradient with dithering → Bug 1981304 - Use fast path more in LinearGradient with dithering
| Assignee | ||
Updated•1 year ago
|
Summary: Use fast path more in LinearGradient with dithering → Use LinearGradient fast path more with dithering
| Assignee | ||
Updated•1 year ago
|
Summary: Use LinearGradient fast path more with dithering → Use linear gradient fast path as much as possible when dithering is enabled
| Assignee | ||
Updated•1 year ago
|
Summary: Use linear gradient fast path as much as possible when dithering is enabled → More eagerly optimize linear gradient when dithering is enabled
Updated•1 year ago
|
Attachment #9505368 -
Attachment description: Bug 1981304 - Use fast path more in LinearGradient with dithering → Bug 1981304 - More eagerly optimize linear gradient when dithering is enabled
Pushed by sikeda.birchill@mozilla.com:
https://github.com/mozilla-firefox/firefox/commit/69d60d22ea93
https://hg.mozilla.org/integration/autoland/rev/929b853f148c
More eagerly optimize linear gradient when dithering is enabled r=gfx-reviewers,gw,lsalzman
Comment 4•1 year ago
|
||
| bugherder | ||
Status: NEW → RESOLVED
Closed: 1 year ago
status-firefox143:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 143 Branch
Updated•1 year ago
|
QA Whiteboard: [qa-triage-done-c144/b143]
You need to log in
before you can comment on or make changes to this bug.
Description
•