1981327 - [toolbar redesign] Add a secret settings in Nightly if the composable toolbar is enabled to allow enabling toolbar redesign

Status: RESOLVED FIXED

(Firefox for Android :: Toolbar, task, P2)

Description

[Petru-Mugurel Lingurar [:petru]]

To get faster and easier feedback of the new toolbar redesign changes we should allow it to be enabled on demand through Secret Settings only if the composable toolbar is already enabled.
Disabling the composable toolbar should also disable the toolbar redesign.

Comment 1

[Petru-Mugurel Lingurar [:petru]]

Attachment: Bug 1981327 - part 1 - Have the toolbar redesign secret setting depend on the composable toolbar r=#android-reviewers

Comment 2

[Petru-Mugurel Lingurar [:petru]]

Attachment: Bug 1981327 - part 2 - Also switch off expanded toolbar layout when toolbar redesign is disabled r=#android-reviewers

We wanted to keep the number of conditions to evaluate for knowing when the
navbar is enabled small so the current code only checks for when the expanded
toolbar layout is enabled or not.
This would allow for a bug in which the redesign with expanded layout is
enabled and then the redesign is disabled but the extended layout preference
still remains leading to the application thinking that it should show the
redesigned toolbar with expanded layout.

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/8729bee87ffa
https://hg.mozilla.org/integration/autoland/rev/f9cf26223484
part 1 - Have the toolbar redesign secret setting depend on the composable toolbar r=android-reviewers,skhan
https://github.com/mozilla-firefox/firefox/commit/0064469b499e
https://hg.mozilla.org/integration/autoland/rev/8282dcd978b7
part 2 - Also switch off expanded toolbar layout when toolbar redesign is disabled r=android-reviewers,skhan

Comment 4

[Narcis Beleuzu [:NarcisB]]

https://hg.mozilla.org/mozilla-central/rev/f9cf26223484
https://hg.mozilla.org/mozilla-central/rev/8282dcd978b7