1981566 - [wpt-sync] Sync PR 54175 - [gap-decorations] Fix underlying GapDataListInterpolationType Checkers

Status: RESOLVED FIXED

(Core :: CSS Parsing and Computation, task, P4)

Description

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Sync web-platform-tests PR 54175 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/54175
Details from upstream follow.

Javier Contreras Tenorio <[e-mail]> wrote:

[gap-decorations] Fix underlying GapDataListInterpolationType Checkers

This CL fixes the Underlying checkers for both GapLengthList and
GapColorList. Other InterpolationTypes (such as LengthList and Color)
don't use these either for MaybeConvertNeutral, and they were leading
to some fuzzer crashes since Equals() are marked as NOTREACHED in
BaseInterpolableColor and InterpolableLength.

The way we fix these is by making the IsValid check to simply check
that the lengths match and that he values in the lists are compatible.

Bug: 357648037
Fixed: 432924205,431949988
Change-Id: I50d0157b5514c80b0cc1b2673faf0536782007f4
Reviewed-on: https://chromium-review.googlesource.com/6777697
WPT-Export-Revision: c084b5bf12d70a18d7d783b9807e0cc68a3d98a7

Comment 1

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Pushed to try (stability) https://treeherder.mozilla.org/#/jobs?repo=try&revision=128c6cd8c1172ed2c98344f7b86828bb1c2987d4

Comment 2

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

CI Results

Ran 0 Firefox configurations based on mozilla-central, and Firefox, Chrome, and Safari on GitHub CI

Total 5 tests

Status Summary

Firefox

OK : 4
PASS : 1
FAIL : 4

Chrome

OK : 2
PASS : 2
CRASH: 3

Safari

OK : 4
PASS : 1
FAIL : 4

Links

GitHub PR Head
GitHub PR Base

Details

New Tests That Don't Pass

• /css/css-gaps/animation/rule-color-interpolation-conversion-001.html [wpt.fyi]
  • CSS gap color change computed value to non compatible value mid-animation: FAIL (Safari: FAIL)
• /css/css-gaps/animation/rule-color-interpolation-conversion-002.html [wpt.fyi]
  • CSS gap color change computed value to compatible value mid-animation: FAIL (Chrome: PASS, Safari: FAIL)
• /css/css-gaps/animation/rule-width-interpolation-conversion-001.html [wpt.fyi]
  • CSS gap width change computed value to non compatible value mid-animation: FAIL (Safari: FAIL)
• /css/css-gaps/animation/rule-width-interpolation-conversion-002.html [wpt.fyi]
  • CSS gap width change computed value to non compatible value mid-animation: FAIL (Chrome: PASS, Safari: FAIL)

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/8610ca0c5e2e
https://hg.mozilla.org/integration/autoland/rev/28dcf9597d2b
[wpt PR 54175] - [gap-decorations] Fix underlying GapDataListInterpolationType Checkers, a=testonly
https://github.com/mozilla-firefox/firefox/commit/596df54f2bde
https://hg.mozilla.org/integration/autoland/rev/39685a4803dc
[wpt PR 54175] - Update wpt metadata, a=testonly

Comment 4

[Iulian Moraru]

https://hg.mozilla.org/mozilla-central/rev/28dcf9597d2b
https://hg.mozilla.org/mozilla-central/rev/39685a4803dc