1981593 - VoiceOver fails to expose selected state for items in multi-group nested listboxes

Status: RESOLVED FIXED

(Core :: Disability Access APIs, defect)

Description

[Morgan Reschenberg [:morgan]]

Hmm, maybe it is an issue with the intervening groups. I tested the difference between these two configs:

URI with identical tree structure to the breakdown above, which produces the same VO behaviour as about:editprofile (tree structure copied for reference):

> listbox
> > group
> > > option (selected)
> > > > group
> > > > > button

data:text/html,
<div role="listbox">
  <div role="group">
    <div role="group">
      <div role="option" aria-selected="true">
        <div role="group">
          <button>hi</button>
        </div>
      </div>
      <div role="option">
        <div role="group">
          <button>hello</button>
      </div>

URI with tree structure like this:

> listbox
> > option (selected)
> > > group
> > > > button

data:text/html,
<div role="listbox">
  <div role="option" aria-selected="true">
    <div role="group">
      <button>hi</button>
    </div>
  </div>
  <div role="option">
    <div role="group">
      <button>hello</button>
     </div>

In the latter, I can navigate through the listbox with VO+arrow keys and hear the selected state.

I think this is because AXSelectedChildren is only set in the latter example, not the former.

-- copied from here

Comment 1

[James Teh [:Jamie]]

Just in case it makes any difference and this wasn't just a typo in the bug comment, role="grouping" is not valid and will result in a generic Accessible, not a grouping Accessible. It should be role="group".

Comment 2

[James Teh [:Jamie]]

But intervening generics should still be ignored completely. In the case in bug 1979693, there is actually both an intervening generic and an intervening grouping.

Comment 3

[Morgan Reschenberg [:morgan]]

(In reply to James Teh [:Jamie] from comment #1)

Just in case it makes any difference and this wasn't just a typo in the bug comment, role="grouping" is not valid and will result in a generic Accessible, not a grouping Accessible. It should be role="group".

ah good catch thank you! I updated #c0 to reflect this. Fortunately both generics and groups compute to AXGroup on the mac platform side, so I think the filtering code I have that uses AXRole should still function

Comment 4

[Morgan Reschenberg [:morgan]]

Attachment: Bug 1981593: Unnest all groups before rendering selected children for listboxes r?eeejay

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/98242a4f9c75
https://hg.mozilla.org/integration/autoland/rev/78b4acbf5719
Unnest all groups before rendering selected children for listboxes r=eeejay

Comment 6

[Cristian Tuns]

https://hg.mozilla.org/mozilla-central/rev/78b4acbf5719