1981668 - [composable toolbar] Sometimes search results are shown in bookmarks and history with no input

Status: VERIFIED FIXED

(Firefox for Android :: Toolbar, defect, P2)

Description

[Petru-Mugurel Lingurar [:petru]]

Attachment: issue.png

Steps to reproduce

1. While in bookmarks or search add a search query while using a general search engine (like Google)
2. Keep the back button on the keyboard pressed to deleted all input (it's important to not delete characters one by one for the bug to happen)

Expected behavior

When there is no input in the toolbar there should be no suggestions shown

Actual behavior

Sometimes suggestions are shown

Comment 1

[Petru-Mugurel Lingurar [:petru]]

Attachment: Bug 1981668 - Avoid showing search suggestions in bookmarks and history if no search query r=#android-reviewers

Matches the flow for searches in home or browser.

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/399bb766b2db
https://hg.mozilla.org/integration/autoland/rev/7accd97e9070
Avoid showing search suggestions in bookmarks and history if no search query r=android-reviewers,harrisono

Comment 3

[Narcis Beleuzu [:NarcisB]]

https://hg.mozilla.org/mozilla-central/rev/7accd97e9070

Comment 4

[Mira Lobontiu (Android QA)]

Verified as fixed on the latest Firefox for Android Nightly 144.0a1 from 8/25 with a Pixel 6 (Android 16), and an Oppo Find X3 Lite (Android 11) that when there are no search results displayed when there is no input in the toolbar.