Closed Bug 1981717 Opened 2 months ago Closed 2 months ago

Inconsistent Important Dates Suggestions

Categories

(Firefox :: Address Bar, defect, P1)

Product:
Firefox
Component:
Address Bar
Version:
Firefox 143
Platform:
Desktop
All
Type:
defect

Tracking

()

Status:
VERIFIED FIXED
Milestone:
143 Branch
Tracking Flags:
Tracking Status
firefox143 --- verified

People

(Reporter: dlucaci, Assigned: mbeier)

References

Details

(Whiteboard: [sng])

Attachments

(1 file)

Bug 1981717 - Don't count important date suggestions towards the one suggestion limit. r?adw
48 bytes, text/x-phabricator-request
Details | Review

Found in

  • Nightly 143.a1

Affected versions

  • Nightly 143.a1

Tested platforms

  • Affected platforms: macOS 14, Windows 10, Ubuntu 22.04

Preconditions

  • browser.urlbar.quicksuggest.dynamicSuggestionTypes = important_dates
  • browser.urlbar.quicksuggest.enabled = true
  • browser.urlbar.suggest.quicksuggest.nonsponsored = true
  • Use remote-settings dev server

Steps to reproduce

  1. Enter in the address bar a popular holiday/event (e.g. Mother's Day).
  2. Observe the Important Dates suggestion in the address bar drop-down.

Expected result

  • The Important Dates suggestion is displayed in the address bar drop-down.

Actual result

  • The Important Dates suggestion is missing from the address bar drop-down.

Regression range

  • Not a regression.

Notes

  • Here is a short list of some of the days/events for which Important Dates suggestions are not displayed:
    Inauguration Day; Lunar New Year; Holi; Good Friday; Cinco de Mayo; Mother's Day; Memorial Day; Flag Day; Father's Day; Independence Day; Halloween; Thanksgiving Day; Black Friday; Christmas Eve.
  • I also tried using other alternate-keywords, but without any success.
Summary: Important Date suggestions are missing from the address bar drop-down for certain popular holidays/events → Important Date suggestions can clash with other suggestions
See Also: → 1982025

We logged a new issue for this problem "Important Date suggestions can clash with other suggestions" (bug 1982022).

We’ll keep this issue as "Inconsistent Important Dates Suggestions" , since, in this issue, some events or holidays appear depending on the number of characters typed and the OS processor.

Summary: Important Date suggestions can clash with other suggestions → Inconsistent Important Dates Suggestions
Assignee: nobody → mbeier
Status: NEW → ASSIGNED
Severity: -- → S2
Priority: -- → P1
Whiteboard: [sng]
Attachment #9506070 - Attachment description: Bug 1981717 - Don't count utility suggestions towards the one suggestion limit. r?adw → Bug 1981717 - Allow showing date suggestions alongside non top pick suggestions. r?adw
Attachment #9506070 - Attachment description: Bug 1981717 - Allow showing date suggestions alongside non top pick suggestions. r?adw → Bug 1981717 - Don't count important date suggestions towards the one suggestion limit. r?adw
Pushed by mbeier@mozilla.com: https://github.com/mozilla-firefox/firefox/commit/32530af37dc7 https://hg.mozilla.org/integration/autoland/rev/37004c2e6812 Don't count important date suggestions towards the one suggestion limit. r=adw,urlbar-reviewers

https://hg.mozilla.org/mozilla-central/rev/37004c2e6812

Status: ASSIGNED → RESOLVED
Closed: 2 months ago
status-firefox143: affected → fixed
Resolution: --- → FIXED
Target Milestone: --- → 143 Branch
QA Contact: dlucaci

Verified as fixed with Firefox 143.0a1 (20250818083741) on macOS 14, Windows 10 and Ubuntu 22.

Status: RESOLVED → VERIFIED
QA Whiteboard: [QA-4258][qa-found-in-c143] → [QA-4258][qa-found-in-c143][qa-ver-done-c143/b142]
status-firefox143: fixed → verified
Duplicate of this bug: 1982022
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: