1981752 - Artifact builds take a long time to package crash reporter symbols even though they should be unmodified

Status: RESOLVED FIXED

(Firefox Build System :: General, defect)

Description

[Florian Quèze [:florian]]

Profiling an artifact build on try with --env MOZ_PROCESS_SAMPLING, I noticed more than 1 minute is spent on zip -r5D ../target.crashreporter-symbols.zip . -i *.sym -i *.txt (out of a 5 minute total time for the entire build): https://share.firefox.dev/47iGnwg

This was a surprise to me as on non-artifact builds buildsymbols happens in parallel to package: https://share.firefox.dev/3HnnvBS

Profile with the patch: https://share.firefox.dev/4fuo6yr

Comment 1

[Florian Quèze [:florian]]

Attachment: Bug 1981752 - in artifact builds, copy the symbols directly to the upload dir instead of repackaging them, r=#firefox-build-system-reviewers.

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/78fa3f68779e
https://hg.mozilla.org/integration/autoland/rev/a15539d04f21
in artifact builds, copy the symbols directly to the upload dir instead of repackaging them, r=firefox-build-system-reviewers,nalexander.

Comment 3

[Serban Stanca [:SerbanS]]

https://hg.mozilla.org/mozilla-central/rev/a15539d04f21